Update Gradle to 9.0 #1428
Merged
Update Gradle to 9.0 #1428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koperagen
force-pushed
the
gradle-update
branch
from
28159e4 to
bac6be3
Compare
Jolanrensen
reviewed
Sep 4, 2025
Jolanrensen
reviewed
Sep 4, 2025
Jolanrensen
approved these changes
Sep 4, 2025
There was a problem hiding this comment.
Issue is probably related to: gradle/gradle#34442. I face the same issue in KoDEx. Somehow, even with isolated classpath workers, Gradle 8.14 runs plugins with Kotlin 2.0.21.
To fix it, both KoDEx and DataFrame needs to build with Gradle 9+, so this also helps #1423, thanks :) (now if only I can get KoDEx to run with Gradle 9...)
Not sure about removing addSamplesToGit so easily. It makes sure all things generated by Korro are added to git automatically... On the other hand, the generated-sources bot also does this manually, so it probably shouldn't be an issue.
Jolanrensen
added
the
infrastructure
koperagen
force-pushed
the
gradle-update
branch
from
bac6be3 to
9ccfe23
Compare
Jolanrensen
reviewed
Sep 5, 2025
koperagen
force-pushed
the
gradle-update
branch
2 times, most recently
from
39c4fa6 to
98f7b2e
Compare
Our old Gradle plugin requires Kotlin 2.2.0 in Gradle runtime to work, because ParseKt refers to the new kotlin.time.Instant class Removing SimpleGit because it's for now incompatible with 9.0
koperagen
force-pushed
the
gradle-update
branch
from
98f7b2e to
0d7c35a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our old Gradle plugin requires Kotlin 2.2.0 in Gradle runtime to work, because ParseKt refers to the new kotlin.time.Instant class and for 8.14.2 + 1.0.0-dev-8342 generate schema task fails ClassNotFound exception. (this problem itself bothers me a little, but ok)
Removing SimpleGit because it's for now incompatible with 9.0