Skip to content

Conversation

JSMonk
Copy link
Member

@JSMonk JSMonk commented Mar 8, 2024

…ication

@bashor bashor requested a review from igoriakovlev September 1, 2025 17:48
}

rootProject.the<NodeJsRootExtension>().apply {
nodeVersion = "21.0.0-v8-canary202309143a48826a08"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we need canary?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it is better not to commit .lock?

kotlin.code.style=official

# To enable K2 Kotlin compiler uncomment the next line
#kotlin.experimental.tryK2=true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is it commented?

}
val syncTask = tasks.named<DefaultIncrementalSyncTask>(taskName)

into(syncTask.get().destinationDirectory.get())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks strange to use get instead of map in configuration phase

@JSMonk
Copy link
Member Author

JSMonk commented Sep 2, 2025

@igoriakovlev Unfortunately, I don't have enough time to maintain this branch. If it's possible, please let someone from the K/Wasm team take care of this branch 🙏

@igoriakovlev igoriakovlev force-pushed the add-c-browser-interop-example branch 2 times, most recently from de78ffa to 9491bfe Compare September 2, 2025 12:12
@igoriakovlev igoriakovlev force-pushed the add-c-browser-interop-example branch from 9491bfe to 5f781d2 Compare September 2, 2025 12:14
@igoriakovlev igoriakovlev merged commit 7ccc848 into main Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants