Refactor ApiHeaderValidationMiddleware:

[cn-tools]

Hi, I made these changes because I'm having a problem with an Android app where a "charset" is also included in the Content-Type header.

For example: Content-Type "application/json; charset=utf-8".

Copilot also confirmed in a code review that the character set can be included here. Android also includes the "charset" by default.

The following changes was made:

• Enhance ApiHeaderValidationMiddleware to support additional HTTP methods and improve content negotiation logic (RFC9110, RFC8259)
• update tests for correct header handling

[codacy-production]

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 duplication

Metric	Results
Duplication	0

View in Codacy

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.}

[Kovah]

Hi there, were those changed made because of a real necessity or issues you had with the way it worked before? Your description is a little sparse on that.

[cn-tools]

Hi there, i add more infos in the first comment. ;)

[Kovah]

Alright, sounds good. Could you please extend the tests with your specific use case?

[cn-tools]

After an additional research, i made a full rework based on RFC 9110 and RFC 8259. The tests are extended too.

[Copilot]

Pull request overview

This PR refactors API header validation to better handle JSON media types with parameters and improve API content negotiation behavior.

Changes:

• Adds parsing for Content-Type values such as application/json; charset=utf-8.
• Introduces Accept-header negotiation with q-values and wildcard handling.
• Adds happy-path middleware tests for charset and q-value Accept headers.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
app/Http/Middleware/ApiHeaderValidationMiddleware.php	Refactors API header validation, content negotiation, and error response generation.
tests/Middleware/ContentTypeHeaderValidationMiddlewareTest.php	Adds new success cases for charset and Accept-header handling.

[Kovah]

Most looks good, still unsure about the response format. Will have to think about that.
In the meantime, could you have a look at failing tests?

[Kovah]

I have taken another look at this and there are three changes I would like to comment on:

• As far as I understand 9110 and the related parts, a missing Accept should be handled as */*, but the code currently rejects those requests. This should be changed.
• The error format, although now compliant to 7807, it diverges from the current standard and I see no significant reason to make this breaking change right now. This should be changed back to the old format.
• $this->isApiRequest($request) should be removed, as the middleware is applied to API requests only.