fix(#1354): restore thin per-role marker outline — keep #1334 shapes, fix heavy stroke#1355
Closed
Kpa-clawbot wants to merge 1 commit into
Closed
fix(#1354): restore thin per-role marker outline — keep #1334 shapes, fix heavy stroke#1355Kpa-clawbot wants to merge 1 commit into
Kpa-clawbot wants to merge 1 commit into
Conversation
RED commit. Asserts window.ROLE_STROKE map + per-role stroke-width / stroke-opacity emitted by makeRoleMarkerSVG: - repeater: width 1.5, opacity 0.6 - companion/room/sensor/observer/unmapped: width 0.5, opacity 0.3 - stroke color stays #fff Wires the new test into deploy.yml JS unit-tests step alongside test-issue-1293-marker-shapes.js. Refs #1354
Owner
Author
|
Superseded by PR #1347 (merged) which implemented the same outline fix. Closing this dup. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DRAFT — opening to fire CI on RED commit. Will replace body before marking ready.