Refactor: replace hardcoded literals with shared constants and add guardrails - #71
Merged
Conversation
Agaki00
changed the title
Change crate-type from ["lib"] to ["cdylib", "lib"] on all six deployable contracts so `stellar contract build` produces wasm artifacts (previously it silently built nothing). Gate stake-vault's #[contract]/#[contractimpl] behind the "contract" feature (in a contract_impl module, matching badge-nft/reward-pool) to avoid duplicate symbol linker errors when quest-engine links it as a dependency. Re-export StakeVault/StakeVaultClient at the crate root so tests and dependents keep working. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
A merge conflict resolution dropped SpenderRemoved from the contract_impl use-list while keeping the remove_approved_spender function that emits it, causing E0422 (struct not found in scope) and failing CI. Re-add the import. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ardrails
name: Pull request
about: Submit changes for review
title: ''
Summary
Use shared constants in contract logic and add guardrails
add regression tests covering the new behavior
Test plan
Checklist
cargo fmt --checkpassescargo clippy -D warningspassescargo testpasses