fix(publish): localize fallback publish errors#362
Merged
Conversation
Staging self-hosted Redis Cluster rehearsals require client TLS material for app traffic. Document the CA, client certificate, and client key config paths alongside cluster endpoint settings. Operators can follow the cutover note without missing mTLS client authentication.
Publish fallback errors moved into a shared helper and lost access to dashboard translations. Allow callers to provide localized fallback formatters and pass translated platform labels from the workflow. Fallback publish toasts no longer expose raw platform ids or hard-coded English copy.
The publish helper now relies on callers to provide localized fallback messages. Add coverage for failed publish fallbacks and missing queued publication status fallbacks. The tests guard against reintroducing hard-coded helper copy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
Implementation Approach
Testing
pnpm --filter frontend exec oxfmt --check 'src/app/[locale]/dashboard/content/_lib/publish-content.ts' 'src/app/[locale]/dashboard/content/_lib/publish-content.test.ts' 'src/app/[locale]/dashboard/content/_workflows/use-content-publish-workflow.ts'pnpm --filter frontend type-checkpnpm --filter frontend test -- 'src/app/[locale]/dashboard/content/_lib/publish-content.test.ts'(Vitest ran 41 files, 175 tests)git diff --check origin/main...HEADbash script/ci/kubernetes.shpassed kustomize render/schema validation and Ruby tests before failing at the Redis capacity alert promtool container step because the local Docker/OrbStack socket/Users/kurodakayn/.orbstack/run/docker.sockwas unavailable.