Skip to content

chore: fix some minor issues in comments #2696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jishudashen wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: fix some minor issues in comments #2696

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/kyberswap-interface/cypress/e2e/specs/swap.e2e.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ describe(`Swap ${NETWORK}`, () => {
cy.intercept('GET', '**/routes?**').as('get-route')
cy.wait('@get-route', { timeout: 20000 }).its('response.statusCode').should('be.oneOf', [200, 404, 408])
})
it('verify the defaul pair', () => {
it('verify the default pair', () => {
SwapPage.getCurrentTokenIn(text => {
expect(text).to.equal('ETH')
})
Expand Down
2 changes: 1 addition & 1 deletion packages/pancake-liquidity-widgets/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ feePcm | fee percentage in per cent mille (0.001% or 1 in 100,000). Ignored if f
includedSources | List of liquidty sources you want to include from your zap, separate by comma | [KyberSwap Aggregator Dex Ids](https://docs.kyberswap.com/kyberswap-solutions/kyberswap-aggregator/dex-ids) |
excludedSources | List of liquidty sources you want to exclude from your zap, separate by comma | [KyberSwap Aggregator Dex Ids](https://docs.kyberswap.com/kyberswap-solutions/kyberswap-aggregator/dex-ids) |
onDismiss | Callback function when click cancel or close widget | () => void |
onTxSubmit | Callback function when tx was submited | (txHash: string) => void |
onTxSubmit | Callback function when tx was submitted | (txHash: string) => void |
onConnectWallet | function when user click connect wallet | () => void |
onAddTokens | Callback function when tokens are added, need to add theses tokens's address into `initDepositTokens`. [Example](https://github.com/KyberNetwork/kyberswap-interface/blob/pancake-zap-in-widget/src/pages/LiquidityWidget.tsx#L69-L79) | (tokenAddresses: string) => void | Required
onRemoveToken | Callback function when a token is removed, need to remove this token's address from `initDepositTokens` and corresponding amount in `initAmounts`. [Example](https://github.com/KyberNetwork/kyberswap-interface/blob/pancake-zap-in-widget/src/pages/LiquidityWidget.tsx#L82-L95) | (tokenAddress: string) => void | Required
Expand Down
2 changes: 1 addition & 1 deletion packages/utils/src/crypto/address.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export const isAddress = (address: string): boolean => {
* Checks if the given string is a checksummed address
*
* @method isChecksumAddress
* @param {string} addr the given HEX adress
* @param {string} addr the given HEX address
* @return {boolean}
*/
export const isChecksumAddress = (addr: string): boolean => {
Expand Down
2 changes: 1 addition & 1 deletion packages/zap-migration-widgets/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,5 +37,5 @@ feePcm | fee percentage in per cent mille (0.001% or 1 in 100,000). Ignored if f
includedSources | List of liquidty sources you want to include from your zap, separate by comma | [KyberSwap Aggregator Dex Ids](https://docs.kyberswap.com/kyberswap-solutions/kyberswap-aggregator/dex-ids) |
excludedSources | List of liquidty sources you want to exclude from your zap, separate by comma | [KyberSwap Aggregator Dex Ids](https://docs.kyberswap.com/kyberswap-solutions/kyberswap-aggregator/dex-ids) |
onDismiss | Callback function when click cancel or close widget | () => void |
onTxSubmit | Callback function when tx was submited | (txHash: string) => void |
onTxSubmit | Callback function when tx was submitted | (txHash: string) => void |
onConnectWallet | function when user click connect wallet | () => void |