feat(earns): sync smart exit invert price across pool price condition#3060
Open
feat(earns): sync smart exit invert price across pool price condition#3060
Conversation
Lift state from PoolPrice up to the SmartExit modal and thread it through Metrics → MetricSelect → PriceInput so the right-pane pool price condition (label, typed input, slider, and comparator ≥/≤) now inverts alongside the left-pane display. PriceInput keeps the stored in the forward (token0/token1) domain so the backend payload and Confirmation screen stay untouched, while and local state sit in the display domain via / helpers. is unchanged since it consumes the forward condition. The debounced input commit uses a latest-ref pattern to avoid stale closures when toggles mid-debounce and to prevent parent re-renders from resetting the timer.
Auto Deploy Pull RequestADPR instance has been created! Information
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lift state from PoolPrice up to the SmartExit modal and thread it through Metrics → MetricSelect → PriceInput so the right-pane pool price condition (label, typed input, slider, and comparator ≥/≤) now inverts alongside the left-pane display.
PriceInput keeps the stored in the forward
(token0/token1) domain so the backend payload and Confirmation screen stay untouched, while and local state sit in
the display domain via / helpers.
is unchanged since it consumes the forward
condition. The debounced input commit uses a latest-ref pattern to avoid stale closures when toggles mid-debounce and to prevent parent re-renders from resetting the timer.