Upgrade .NET 3.1 => 8.0 #65
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notatiyyah
commented
Jan 20, 2025
| Environment.SetEnvironmentVariable("jwtSecret", _fixture.Create<string>()); | ||
| Environment.SetEnvironmentVariable("hackneyUserAuthTokenJwtSecret", _faker.Random.AlphaNumeric(25)); | ||
| Environment.SetEnvironmentVariable("jwtSecret", _faker.Random.AlphaNumeric(50)); | ||
| Environment.SetEnvironmentVariable("hackneyUserAuthTokenJwtSecret", _faker.Random.AlphaNumeric(50)); |
There was a problem hiding this comment.
Had to lengthen the string to meet the new security requirements
See here.
notatiyyah
commented
Jan 20, 2025
| @@ -17,6 +17,7 @@ public static void Configure(this IServiceCollection services) | |||
|
|
|||
| var connectionString = Environment.GetEnvironmentVariable("CONNECTION_STRING"); | |||
|
|
|||
| AppContext.SetSwitch("Npgsql.EnableLegacyTimestampBehavior", true); | |||
There was a problem hiding this comment.
This is to allow the database timestamps to be converted
notatiyyah
commented
Jan 20, 2025
| @@ -1,22 +1,22 @@ | |||
| .PHONY: setup | |||
| setup: | |||
| docker-compose build | |||
| docker compose build | |||
There was a problem hiding this comment.
docker compose is more up to date and faster than docker-compose.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade API to .NET 8.0 as 6.0 has reached End of Support.
TODO BEFORE MERGING:
This PR updates the
System.IdentityModel.Tokens.Jwtpackage, including a vulnerability fix. See here for more details. Before merging, we need to confirm the key we use fits the new security requirements or this will introduce breaking changes.