feat(prover-ray): adds demo using Zesu - #3690
Draft
AlexandreBelling wants to merge 1 commit into
Draft
Conversation
Signed-off-by: AlexandreBelling <alexandrebelling8@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces Go benchmarks in prover-ray to measure ZkC-based EVM execution tracing and a full prove+verify cycle, and updates the zkc dependency accordingly.
Changes:
- Add
BenchmarkEvmExecutionTrace(constraint evaluation) andBenchmarkEvmExecutionProveVerify(prove+verify) benchmarks for the EVM execution guest input. - Update
compileBinaryConstraintsto usezkcCfg.GetMaxStaticHeight()when building the ZkCBinaryFile. - Bump
github.com/LFDT-Lineth/zkctov1.2.26-0.20260803055626-603a1f9a6bde(and refreshgo.sum).
Reviewed changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| prover-ray/zkcdriver/zkcdriver_test.go | Updates binary constraints compilation to use the new config accessor (GetMaxStaticHeight). |
| prover-ray/zkcdriver/evm_execution_bench_test.go | Adds two benchmarks for tracing and prove+verify using the EVM execution guest input. |
| prover-ray/go.mod | Bumps github.com/LFDT-Lineth/zkc to a newer pseudo-version. |
| prover-ray/go.sum | Updates checksums for the bumped zkc version (and related indirect sum churn). |
Suppressed comments (1)
prover-ray/zkcdriver/evm_execution_bench_test.go:66
- Same as above: this comment claims the input file is not checked in, but
testdata/evm_execution_guest.jsonis present in the repo. Reword to “if missing, generate it …” to keep the instructions accurate.
// The input file is not checked in; generate it with:
//
// make -C riscv-guests/l2-execution exec # from the monorepo root
Comment on lines
+25
to
+27
| // The input file is not checked in; generate it with: | ||
| // | ||
| // make -C riscv-guests/l2-execution exec # from the monorepo root |
Comment on lines
61
to
64
| return nil, fmt.Errorf("failed to compile zkc source") | ||
| } | ||
| binfile = constraints.NewBinaryFile[koalabear.Element](nil, nil, zkcField, zkcCfg.GetMaxStaticDepth(), ir) | ||
| binfile = constraints.NewBinaryFile[koalabear.Element](nil, nil, zkcField, zkcCfg.GetMaxStaticHeight(), ir) | ||
| return binfile, nil |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a benchmark for using the tracer and the prover with Zesu.