fix(prover): make WriterstoEqual actually compare both encodings - #3732
Open
coeniebeyers wants to merge 2 commits into
Open
fix(prover): make WriterstoEqual actually compare both encodings#3732coeniebeyers wants to merge 2 commits into
coeniebeyers wants to merge 2 commits into
Conversation
Signed-off-by: Marelize <marelize.kriel@adhara.io> Signed-off-by: Coenie Beyers <coenie.beyers@adhara.io>
…test Signed-off-by: Coenie Beyers <coenie.beyers@adhara.io>
This was referenced Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3731.
WriterstoEqualserialized both operands into one reusedbytes.Buffer; the buffer's backing array survivesReset(), so the comparison matched a slice against itself and any two same-length encodings compared equal. This madeLoadSetup's verifying-key↔SRS check always pass, silently.Each operand now gets its own buffer. Includes table-driven tests plus
TestWriterstoEqual_Regression_SameLengthDifferentContent, which fails on the previous implementation, and a doc-comment correction ("reports whether" implied a boolean return).Fix authored by @mkrielza.
Checklist
No breaking API changes.