ci: only suppress coordinator-review findings from closed issues - #3739
Open
SashaMIT wants to merge 1 commit into
Open
ci: only suppress coordinator-review findings from closed issues#3739SashaMIT wants to merge 1 commit into
SashaMIT wants to merge 1 commit into
Conversation
The weekly coordinator review builds its skip-list from issue bodies in --state all, so the moment the agent reports a finding (open issue), every future review skips that location forever - even while the issue is unaddressed. Suppression now keys on closed issues only, matching the prompt's intent (resolved or explicitly declined findings).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The weekly coordinator security review builds its suppression list by grepping issue bodies with
--state all:The prompt then tells the agent to "skip any finding whose primary file:line location appears in that file — do not re-report it even if the issue is still present."
Because open issues are included, every finding the agent reports immediately suppresses itself: the issue is filed (open), its body contains the file:line, and every subsequent weekly review skips that location — even if nobody ever fixes the underlying issue. The review's coverage of live, unaddressed findings decays to zero over time.
Fix
--state closed: suppression now keys on issues a human or process actually closed (resolved / won't-fix / false-positive). Findings in still-open issues are re-reported until someone acts on them — which is the point of a recurring review. The prompt text is updated to match.Notes
Made with Cursor
Made with Cursor