feat: simplify lookups - #2114
Merged
DavePearce merged 1 commit intoAug 7, 2026
Merged
Conversation
DavePearce
force-pushed
the
2111-feat-simplify-lookup-constraints-to-support-registers-only
branch
2 times, most recently
from
August 6, 2026 22:14
f5bb97f to
5ddbc59
Compare
Lookup sources, targets and selectors must now be column accesses rather than arbitrary expressions, simplifying the parser, resolver and translator since a lookup no longer synthesises computed columns for its operands. Every test which relied on an expression in a deflookup / defclookup has been rewritten to introduce a temporary register holding the value of that expression, defined by an ordinary vanishing constraint, with the corresponding accepts / rejects traces updated to supply the new column; constant selectors (as in valid/lookup_23 and agnostic/lookup_06) become columns with ":padding 1" so that the implicit padding row behaves exactly as before. Each reject trace was checked to still fail because of its lookup, rather than because of the constraint defining its temporary register. Signed-off-by: DavePearce <dave01001110@gmail.com>
DavePearce
force-pushed
the
2111-feat-simplify-lookup-constraints-to-support-registers-only
branch
from
August 6, 2026 23:56
5ddbc59 to
5d14895
Compare
letypequividelespoubelles
approved these changes
Aug 7, 2026
letypequividelespoubelles
left a comment
letypequividelespoubelles
left a comment
Contributor
There was a problem hiding this comment.
almost blind approval
DavePearce
deleted the
2111-feat-simplify-lookup-constraints-to-support-registers-only
branch
August 7, 2026 03:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lookup sources, targets and selectors must now be column accesses rather than arbitrary expressions, simplifying the parser, resolver and translator since a lookup no longer synthesises computed columns for its operands. Every test which relied on an expression in a deflookup / defclookup has been rewritten to introduce a temporary register holding the value of that expression, defined by an ordinary vanishing constraint, with the corresponding accepts / rejects traces updated to supply the new column; constant selectors (as in valid/lookup_23 and agnostic/lookup_06) become columns with ":padding 1" so that the implicit padding row behaves exactly as before. Each reject trace was checked to still fail because of its lookup, rather than because of the constraint defining its temporary register.