Improve CSP

[HayimShaul]

Improve the CSP ZKP

co-authored with: @kushnireyal

[adecaro]

Hi @HayimShaul , thanks for this effort. It looks promising. Please, fix the errors reported by the CI so we can check if the tests are passing. Please, also run the benchmarks to understand which improvements this PR brings in.
Thanks 🙏

@neetance , you might be interested in having a look at this as well. Thanks 🙏

[adecaro]

Hi @HayimShaul , please, run the benchmark with and without the optimization to see what's the gain. Please, post the result here. Thanks 🙏

[AkramBitar]

@HayimShaul could you please open an issue and attached it to this PR. Please put the issue under the generic EPIC.

[HayimShaul]

Here are the benchmarks

IPA
Real Throughput: 846.80/s -> 908.85/s (+7.3% improvement)
Pure Throughput: 847.04/s -> 909.07/s (+7.3% improvement)
Allocs: 9079 Allocs/op -> 9126 Allocs/op (+0.5% worse - practically the same)
Average: 75.55ms -> 70.40ms (6.9% faster)
P50: 66.20ms -> 65.02ms (1.8% faster)

BF
Real Throughput: 884.60/s -> 887.18/s (practically the same)
Pure Throughput: 884.77/s -> 887.39/s (practically the same)
Allocs: 7598 Allocs/op -> 7580 Allocs/op (practically the same)
Average: 72.33ms -> 72.12ms (practically the same)
P50: 68.61ms -> 68.39ms (practically the same)

The raw benchmark output:

IPA before optimizations

go test -v ./token/core/zkatdlog/nogh/v1/crypto/rp/bulletproof/... -run TestParallelIPAProver -count=1 -args -duration=300s
=== RUN   TestParallelIPAProver
=== RUN   TestParallelIPAProver/Setup(bits_32,_curve_BN254,_#i_2,_#o_2)_with_64_workers
Metric           Value     Description
------           -----     -----------
Workers          64        
Total Ops        254097    (Robust Sample)
Duration         5m0.066s  (Good Duration)
Real Throughput  846.80/s  Observed Ops/sec (Wall Clock)
Pure Throughput  847.04/s  Theoretical Max (Low Overhead)

Latency Distribution:
 Min           17.114115ms   
 P50 (Median)  66.206006ms   
 Average       75.557523ms   
 P95           136.106531ms  
 P99           258.92779ms   
 P99.9         606.836611ms  
 Max           1.467003162s  (Stable Tail)

Stability Metrics:
 Std Dev  48.678587ms  
 IQR      40.385421ms  Interquartile Range
 Jitter   34.772684ms  Avg delta per worker
 CV       64.43%       Unstable (>20%) - Result is Noisy

System Health & Reliability:
 Error Rate          0.0000%          (100% Success) (0 errors)
 Memory              987112 B/op      Allocated bytes per operation
 Allocs              9079 allocs/op   Allocations per operation
 Alloc Rate          724.88 MB/s      Memory pressure on system
 GC Overhead         23.78%           (Severe GC Thrashing)
 GC Pause            1m11.361744841s  Total Stop-The-World time
 GC Cycles           19570            Full garbage collection cycles
 Goroutines Created  1496             Net goroutines above baseline during recording

Latency Heatmap (Dynamic Range):
Range                       Freq   Distribution Graph
 17.114115ms-21.380028ms    76      (0.0%)
 21.380028ms-26.709275ms    943     (0.4%)
 26.709275ms-33.366905ms    9537   ███████ (3.8%)
 33.366905ms-41.684036ms    30925  ████████████████████████ (12.2%)
 41.684036ms-52.074318ms    31483  █████████████████████████ (12.4%)
 52.074318ms-65.054512ms    49953  ████████████████████████████████████████ (19.7%)
 65.054512ms-81.270186ms    47876  ██████████████████████████████████████ (18.8%)
 81.270186ms-101.527826ms   41205  ████████████████████████████████ (16.2%)
 101.527826ms-126.834942ms  24871  ███████████████████ (9.8%)
 126.834942ms-158.450184ms  10326  ████████ (4.1%)
 158.450184ms-197.94593ms   3015   ██ (1.2%)
 197.94593ms-247.2865ms     1147    (0.5%)
 247.2865ms-308.925841ms    871     (0.3%)
 308.925841ms-385.929581ms  738     (0.3%)
 385.929581ms-482.127494ms  533     (0.2%)
 482.127494ms-602.303974ms  331     (0.1%)
 602.303974ms-752.435988ms  169     (0.1%)
 752.435988ms-939.990337ms  72      (0.0%)
 939.990337ms-1.174295021s  20      (0.0%)
 1.174295021s-1.467003162s  6       (0.0%)

--- Analysis & Recommendations ---
[FAIL] High Variance (CV 64.43%). System noise is affecting results. Isolate the machine or increase duration.
[INFO] High Allocations (9079/op). This will trigger frequent GC cycles and increase Max Latency.
----------------------------------

--- Throughput Timeline ---
Timeline: [▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇█▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▆▆▇▆▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▃▂ ▂▂▂▅▇▆▃▂▂ ▂▃▂▂▂▂▂▂▂▃▃▂▂▂▅▅▆▆▆▅▆▅] (Max: 978 ops/s)

--- PASS: TestParallelIPAProver (303.28s)
    --- PASS: TestParallelIPAProver/Setup(bits_32,_curve_BN254,_#i_2,_#o_2)_with_64_workers (303.28s)
PASS
ok      github.com/LFDT-Panurus/panurus/token/core/zkatdlog/nogh/v1/crypto/rp/bulletproof       303.334s

IPA after optimizations

go test -v ./token/core/zkatdlog/nogh/v1/crypto/rp/bulletproof/... -run TestParallelIPAProver -count=1 -args -duration=300s
=== RUN   TestParallelIPAProver
=== RUN   TestParallelIPAProver/Setup(bits_32,_curve_BN254,_#i_2,_#o_2)_with_64_workers
Metric           Value     Description
------           -----     -----------
Workers          64        
Total Ops        272698    (Robust Sample)
Duration         5m0.048s  (Good Duration)
Real Throughput  908.85/s  Observed Ops/sec (Wall Clock)
Pure Throughput  909.07/s  Theoretical Max (Low Overhead)

Latency Distribution:
 Min           16.274249ms   
 P50 (Median)  65.023249ms   
 Average       70.401678ms   
 P95           125.222898ms  
 P99           156.730353ms  
 P99.9         196.880151ms  
 Max           352.952508ms  (Stable Tail)

Stability Metrics:
 Std Dev  28.978657ms  
 IQR      38.624345ms  Interquartile Range
 Jitter   31.696379ms  Avg delta per worker
 CV       41.16%       Unstable (>20%) - Result is Noisy

System Health & Reliability:
 Error Rate          0.0000%          (100% Success) (0 errors)
 Memory              1006915 B/op     Allocated bytes per operation
 Allocs              9126 allocs/op   Allocations per operation
 Alloc Rate          778.07 MB/s      Memory pressure on system
 GC Overhead         25.63%           (Severe GC Thrashing)
 GC Pause            1m16.890971022s  Total Stop-The-World time
 GC Cycles           22439            Full garbage collection cycles
 Goroutines Created  1433             Net goroutines above baseline during recording

Latency Heatmap (Dynamic Range):
Range                       Freq   Distribution Graph
 16.274249ms-18.980678ms    11      (0.0%)
 18.980678ms-22.137189ms    112     (0.0%)
 22.137189ms-25.818633ms    559     (0.2%)
 25.818633ms-30.112306ms    3391   ███ (1.2%)
 30.112306ms-35.120022ms    14540  ██████████████ (5.3%)
 35.120022ms-40.960528ms    25639  ████████████████████████ (9.4%)
 40.960528ms-47.772318ms    22240  █████████████████████ (8.2%)
 47.772318ms-55.716917ms    28455  ███████████████████████████ (10.4%)
 55.716917ms-64.982714ms    41231  ████████████████████████████████████████ (15.1%)
 64.982714ms-75.789425ms    36229  ███████████████████████████████████ (13.3%)
 75.789425ms-88.393306ms    35757  ██████████████████████████████████ (13.1%)
 88.393306ms-103.093229ms   28129  ███████████████████████████ (10.3%)
 103.093229ms-120.237769ms  19196  ██████████████████ (7.0%)
 120.237769ms-140.233469ms  10691  ██████████ (3.9%)
 140.233469ms-163.554479ms  4684   ████ (1.7%)
 163.554479ms-190.753804ms  1447   █ (0.5%)
 190.753804ms-222.476413ms  330     (0.1%)
 222.476413ms-259.474534ms  51      (0.0%)
 259.474534ms-302.62549ms   4       (0.0%)
 302.62549ms-352.952508ms   2       (0.0%)

--- Analysis & Recommendations ---
[FAIL] High Variance (CV 41.16%). System noise is affecting results. Isolate the machine or increase duration.
[INFO] High Allocations (9126/op). This will trigger frequent GC cycles and increase Max Latency.
----------------------------------

--- Throughput Timeline ---
Timeline: [▆▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇█▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇] (Max: 986 ops/s)

--- PASS: TestParallelIPAProver (303.25s)
    --- PASS: TestParallelIPAProver/Setup(bits_32,_curve_BN254,_#i_2,_#o_2)_with_64_workers (303.25s)
PASS
ok      github.com/LFDT-Panurus/panurus/token/core/zkatdlog/nogh/v1/crypto/rp/bulletproof       303.296s

BF before optimizations

go test -v ./token/core/zkatdlog/nogh/v1/crypto/rp/bulletproof/... -run TestParallelBFProver -count=1 -args -duration=300s
=== RUN   TestParallelBFProver
=== RUN   TestParallelBFProver/Setup(bits_32,_curve_BN254,_#i_2,_#o_2)_with_64_workers
Metric           Value     Description
------           -----     -----------
Workers          64        
Total Ops        265419    (Robust Sample)
Duration         5m0.045s  (Good Duration)
Real Throughput  884.60/s  Observed Ops/sec (Wall Clock)
Pure Throughput  884.77/s  Theoretical Max (Low Overhead)

Latency Distribution:
 Min           16.94348ms    
 P50 (Median)  68.610813ms   
 Average       72.335122ms   
 P95           122.31939ms   
 P99           149.744865ms  
 P99.9         184.342887ms  
 Max           280.131476ms  (Stable Tail)

Stability Metrics:
 Std Dev  26.964088ms  
 IQR      35.897669ms  Interquartile Range
 Jitter   29.648325ms  Avg delta per worker
 CV       37.28%       Unstable (>20%) - Result is Noisy

System Health & Reliability:
 Error Rate          0.0000%         (100% Success) (0 errors)
 Memory              859228 B/op     Allocated bytes per operation
 Allocs              7593 allocs/op  Allocations per operation
 Alloc Rate          650.95 MB/s     Memory pressure on system
 GC Overhead         26.54%          (Severe GC Thrashing)
 GC Pause            1m19.63823104s  Total Stop-The-World time
 GC Cycles           24783           Full garbage collection cycles
 Goroutines Created  807             Net goroutines above baseline during recording

Latency Heatmap (Dynamic Range):
Range                       Freq   Distribution Graph
 16.94348ms-19.49488ms      25      (0.0%)
 19.49488ms-22.430478ms     204     (0.1%)
 22.430478ms-25.808128ms    1080   █ (0.4%)
 25.808128ms-29.694394ms    3106   ███ (1.2%)
 29.694394ms-34.165866ms    6770   ███████ (2.6%)
 34.165866ms-39.310666ms    11692  ████████████ (4.4%)
 39.310666ms-45.230185ms    17962  ██████████████████ (6.8%)
 45.230185ms-52.041083ms    24205  █████████████████████████ (9.1%)
 52.041083ms-59.877587ms    31949  █████████████████████████████████ (12.0%)
 59.877587ms-68.894136ms    36836  ██████████████████████████████████████ (13.9%)
 68.894136ms-79.268424ms    38033  ████████████████████████████████████████ (14.3%)
 79.268424ms-91.204904ms    34578  ████████████████████████████████████ (13.0%)
 91.204904ms-104.938815ms   27088  ████████████████████████████ (10.2%)
 104.938815ms-120.740819ms  17465  ██████████████████ (6.6%)
 120.740819ms-138.922338ms  9328   █████████ (3.5%)
 138.922338ms-159.841685ms  3671   ███ (1.4%)
 159.841685ms-183.911131ms  1151   █ (0.4%)
 183.911131ms-211.605026ms  235     (0.1%)
 211.605026ms-243.469152ms  39      (0.0%)
 243.469152ms-280.131476ms  2       (0.0%)

--- Analysis & Recommendations ---
[FAIL] High Variance (CV 37.28%). System noise is affecting results. Isolate the machine or increase duration.
[INFO] High Allocations (7593/op). This will trigger frequent GC cycles and increase Max Latency.
----------------------------------

--- Throughput Timeline ---
Timeline: [▆▇▇▇▇▇▇▇▇▇▇▇▇▇▇▆▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇█▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▆▇▇▇▇▇▇▇▇▇▇▇▇▆▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▆▇▇▇▇▇▇▇▇▆▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▆▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▆▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇] (Max: 976 ops/s)

--- PASS: TestParallelBFProver (303.25s)
    --- PASS: TestParallelBFProver/Setup(bits_32,_curve_BN254,_#i_2,_#o_2)_with_64_workers (303.25s)
PASS
ok      github.com/LFDT-Panurus/panurus/token/core/zkatdlog/nogh/v1/crypto/rp/bulletproof       303.295s

BF after optimizations

go test -v ./token/core/zkatdlog/nogh/v1/crypto/rp/bulletproof/... -run TestParallelBFProver -count=1 -args -duration=300s
=== RUN   TestParallelBFProver
=== RUN   TestParallelBFProver/Setup(bits_32,_curve_BN254,_#i_2,_#o_2)_with_64_workers
Metric           Value     Description
------           -----     -----------
Workers          64        
Total Ops        266195    (Robust Sample)
Duration         5m0.047s  (Good Duration)
Real Throughput  887.18/s  Observed Ops/sec (Wall Clock)
Pure Throughput  887.37/s  Theoretical Max (Low Overhead)

Latency Distribution:
 Min           15.340506ms   
 P50 (Median)  68.393873ms   
 Average       72.123139ms   
 P95           122.299597ms  
 P99           149.608482ms  
 P99.9         183.631905ms  
 Max           262.016561ms  (Stable Tail)

Stability Metrics:
 Std Dev  27.162878ms  
 IQR      36.239453ms  Interquartile Range
 Jitter   29.706685ms  Avg delta per worker
 CV       37.66%       Unstable (>20%) - Result is Noisy

System Health & Reliability:
 Error Rate          0.0000%          (100% Success) (0 errors)
 Memory              849292 B/op      Allocated bytes per operation
 Allocs              7580 allocs/op   Allocations per operation
 Alloc Rate          652.79 MB/s      Memory pressure on system
 GC Overhead         25.21%           (Severe GC Thrashing)
 GC Pause            1m15.633183434s  Total Stop-The-World time
 GC Cycles           23913            Full garbage collection cycles
 Goroutines Created  0                Net goroutines above baseline during recording

Latency Heatmap (Dynamic Range):
Range                       Freq   Distribution Graph
 15.340506ms-17.679262ms    14      (0.0%)
 17.679262ms-20.374576ms    149     (0.1%)
 20.374576ms-23.480808ms    652     (0.2%)
 23.480808ms-27.060604ms    2165   ██ (0.8%)
 27.060604ms-31.186163ms    4898   █████ (1.8%)
 31.186163ms-35.940689ms    8682   █████████ (3.3%)
 35.940689ms-41.420072ms    13462  ██████████████ (5.1%)
 41.420072ms-47.734822ms    20312  █████████████████████ (7.6%)
 47.734822ms-55.012294ms    27875  █████████████████████████████ (10.5%)
 55.012294ms-63.399263ms    34689  ████████████████████████████████████ (13.0%)
 63.399263ms-73.064878ms    37843  ████████████████████████████████████████ (14.2%)
 73.064878ms-84.204076ms    37399  ███████████████████████████████████████ (14.0%)
 84.204076ms-97.041515ms    31991  █████████████████████████████████ (12.0%)
 97.041515ms-111.836102ms   23193  ████████████████████████ (8.7%)
 111.836102ms-128.886217ms  13684  ██████████████ (5.1%)
 128.886217ms-148.535728ms  6336   ██████ (2.4%)
 148.535728ms-171.18093ms   2211   ██ (0.8%)
 171.18093ms-197.278536ms   530     (0.2%)
 197.278536ms-227.354884ms  97      (0.0%)
 227.354884ms-262.016561ms  13      (0.0%)

--- Analysis & Recommendations ---
[FAIL] High Variance (CV 37.66%). System noise is affecting results. Isolate the machine or increase duration.
[INFO] High Allocations (7580/op). This will trigger frequent GC cycles and increase Max Latency.
----------------------------------

--- Throughput Timeline ---
Timeline: [▇▇▇▆▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇█▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▆▇▇▇▇▇▆▇▇▇▇▇▇▇▇▇▇▆▇▇▆▇▇▇▇▇▇▆▇▇▇▇▇▇▇▇▇▇▆▇▇▇▆▇▇▇▆▇▆▇▆▇▇▇▇▇▆▇▇▇▇▇▆▇▇▇▇▇▆▇▇▇▇▇▇▇▇▇▇▇▇▇▇▆▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▆▇▇▇▇▇▇▇▇▇▇▇▇▆▇▇▇▇▇▇▇▇▇▆▇▇▇▇▇▇▇▆▇▇▇▇▇▇▇▇▇▇▇▆▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▆▇▇▇▇▇▇▇▇▇▇▇▆▇▇▇▇▆▆▇▆▇▇▇▆▇▇▇▇▇▇▇▇▇▆▇▇▇▇▆▇▇▇▇▇▇▇] (Max: 987 ops/s)

--- PASS: TestParallelBFProver (303.29s)
    --- PASS: TestParallelBFProver/Setup(bits_32,_curve_BN254,_#i_2,_#o_2)_with_64_workers (303.29s)
PASS
ok      github.com/LFDT-Panurus/panurus/token/core/zkatdlog/nogh/v1/crypto/rp/bulletproof       303.375s