[BUG]: RequestSpendView in multisig blocks forever — WithTimeout() exists but is never applied to the channel wait #1671#1890
Open
adecaro wants to merge 1 commit into
Conversation
3021578 to
bbba1b4
Compare
bbba1b4 to
8f8b4b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1671: RequestSpendView.Call() in the multisig and boolpolicy identity services could block forever waiting for a co-signer's answer, since the timeout field/WithTimeout() setter
on multisig.RequestSpendView were dead code (never applied to the wait loop), and boolpolicy.RequestSpendView had no timeout knob at all.
(defaulting to 30s if unset) and honors context cancellation, returning a descriptive wrapped error either way.
previously had none.
the collector itself (all-answers, worker error, timeout, context cancellation, late-send-after-return).
Additional changes
Wrapf, WithMessage, WithMessagef, Join, etc.). Documented this in AGENTS.md and fixed the one violation found in docs/upgradability.md, plus rewrote collector.go's two error sites to
use errors.Join/errors.Wrapf instead of fmt.Errorf.