New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use position of vertices to choose Nemoh mesh file header. #43

Open

mcharlou wants to merge 2 commits into master from better-nemoh-mesh-symmetry-header

Member

mcharlou commented Jan 28, 2025

This MR proposes to set the header for Nemoh mesh files according to the minimum y-position of vertices.

If a vertex is detected with $y<0$, the header is set to 2 0 (no symmetry),
Otherwise (i.e. all vertices have $y \ge 0$), set the header to 2 1 (xOz symmetry).

While not ideal, I believe this is better than the current behaviour (assume no symmetry).


          ♻️ Use position of vertices to choose Nemoh mesh file header.

4cb8993

mcharlou requested a review from frongere

January 28, 2025 18:03


          ➕ Added 'gmshparser' dependency to setup.py.

5d9fe76

Member Author

mcharlou commented Jan 28, 2025

I've also added gmshparser as a dependency in setup.py because it was missing. Unless there was a good reason (e.g. license)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet