-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicitly add clips and tracks to their respective containers #7754
base: master
Are you sure you want to change the base?
Explicitly add clips and tracks to their respective containers #7754
Conversation
…ction when clip is added to the track
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tested it but it looks good to me
To allow for extendable behavior and avoid unncecessary coupling (specifically with patterns)
I have made some changes, in particular, making My next goal, which I might not achieve in this PR, is to remove the |
Note: This will most likely cause crashes and be overall just broken. I want to fix any potential references to the track in the constructor one by one, slowly.
…tness-tracks-clips
This reverts commit 4be2572.
Currently, we add clips and tracks to tracks and track containers in their base classes. As a consequence for adding it to the container before the object has completely finished constructing, the application can crash at selective moments due to the use of an incomplete object (most commonly by usage from the audio thread).
To fix this, callers must now add clips and tracks to their respective containers explicitly after construction has completed.
This is a continuation of #7594, just without being too ambitious to avoid bugs. There is most likely a lot more refactoring that can be done here to make resource management a bit more safe.