Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed name of Sf2 Player to Soundfont Player #7760

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hossanf
Copy link

@hossanf hossanf commented Mar 8, 2025

#5361

Changed the name of Sf2 Player to Soundfont Player.

LMMS#5361

Changed the name of the Sf2 Player to Soundfont Player.
@messmerd
Copy link
Member

It should be "SoundFont" not "Soundfont", and other instances of "Sf2" that aren't public-facing such as class names and file names should also be changed to be consistent.

@hossanf
Copy link
Author

hossanf commented Mar 11, 2025

I thought it was "SoundFont" as well, I spelled it "Soundfont" because thats how it was splled in the issue.

Gotcha, also I was hesitant to change the class names because it was suggested this plugin could be merged with another, but I'll get to it.

Should I create a seperate issue for the icon?

@rubiefawn rubiefawn linked an issue Mar 13, 2025 that may be closed by this pull request
@messmerd
Copy link
Member

Should I create a seperate issue for the icon?

No, might as well do it all in one go

@messmerd
Copy link
Member

Depending on what you change internally, you may need to add an upgrade routine to continue supporting old projects that used "Sf2Player", so just keep that in mind

@rubiefawn
Copy link
Contributor

rubiefawn commented Mar 19, 2025

The PR only modifies the plugin's display name, the plugin internally appears to still be called Sf2Player.

Edit: I totally missed this, my bad lol

other instances of "Sf2" that aren't public-facing such as class names and file names should also be changed to be consistent.

@tresf tresf marked this pull request as draft March 22, 2025 04:56
@tresf
Copy link
Member

tresf commented Mar 22, 2025

Converted to draft until the OP addresses the requested changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the name of Sf2 Player to Soundfont Player
4 participants