Fix Clip Creation Quantization in Song Editor #7763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qnebra
approved these changes
Mar 13, 2025
|
Also tested, looks good! |
rubiefawn
reviewed
Mar 13, 2025
rubiefawn
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you click to add a clip on a track in the Song Editor, it adds it quantized to the previous bar, no matter what the snap size is set to. Similarly, when dragging a sample from the sidebar onto a sample track, the sample clip is created quantized to the last bar, ignoring the snap size.
This PR addresses this issue by adding proper quantization based on the song editor snap size (also subtracting half of the snap size so that it always rounds down).