Conversation
LMS10
added
Priority: Medium 🔖
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Collaborator
|
데이터 페치 함수 분리, 스켈레톤 UI 확인했습니다 수고하셨습니다~!👍 |
qpalkim
approved these changes
Feb 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣ Issue
📝 Description
추천 와인 목록 가져오는 fetchRecommendWine 함수 구현
API 요청 로직을 별도의 함수로 분리하여 관리가 용이하도록 개선하였습니다.
추천 와인 목록 로딩 스켈레톤 컴포넌트 구현
와인 목록이 로딩될 때 사용자에게 로딩 상태를 표시하기 위해 스켈레톤 컴포넌트를 구현했습니다.
fetchRecommendWine 함수로 API 요청 로직 분리 및 로딩 스켈레톤 적용
기존에 컴포넌트 내에서 직접 API 요청을 처리하던 방식을 fetchRecommendWine 함수로 분리하여 코드의 재사용성을 높였고, 로딩 상태에 따라 와인 목록을 로딩하는 동안 스켈레톤을 표시하도록 처리했습니다.
🌀 PR Type
어떤 변경 사항이 있나요?
✅ Checklist
PR Checklist
PR이 다음 요구 사항을 충족하는지 확인하세요.
Test Checklist
Additional Notes