done#972
Conversation
|
heads up: main's ci was broken (the Backend CI and Backend Docker Image CI jobs) until the fixes in #969 and #974 just landed, so the red backend/docker checks on this pr are almost certainly stale, they ran against the broken main. please rebase to re-test against the now-green main: |
okay |
ogazboiz
left a comment
There was a problem hiding this comment.
the deprecated-routes feature itself is coherent: adding the 410-Gone handlers for POST /streams and /events with the deprecated/migration body (main currently 404s via fallthrough, so this is a deliberate behavior change) and updating deprecated.test.ts to match. but a couple of unrelated ci changes need to come out before it can land:
- ci.yml:98 removes the
npm install @vitest/coverage-v8@2.1.9 --no-saveline, but the next step runsvitest run --coverage, so dropping the explicit coverage-v8 install risks re-breaking the coverage job. please keep that install. - the Dockerfile and soroban-event-worker.ts changes are just blank-line / trailing-newline churn, unrelated to the feature, drop them to keep the diff focused.
keep just the 410-handler work (plus the ci.yml:145 --schema flag if you need it), drop the coverage-install removal and the churn, and it's good. also the title "done" isn't descriptive, name it after the deprecated-routes change.
Description
Type of Change
Related Issues
Closes #
Changes Made
Testing
Test Coverage
Test Steps
Breaking Changes
Breaking Changes:
Migration Guide:
Screenshots/Demo
Checklist
Additional Notes
closes #792