Repository navigation
Reject wildcards and malformed addresses as direct_ip - #2619
Merged
Merged
Conversation
A direct_ip like %.pixelhide.net passed with only a misleading offline note. The direct IP and every wildcard now have to be a plain domain or IPv4 address, optionally with a port, and an invalid address skips the server status check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
direct_iplike%.pixelhide.netpassed the validation with only a misleading "could be offline" note.direct_iphas to be a plain domain or IPv4 address, optionally with a port. A wildcard gets its own hint that it belongs intoserver_wildcards, everything else (https://, paths, spaces, no dot) a generic one%., invalid ones are no longer compared against the serverdirect_ipas the address players join, without wildcardsTested against the manifest of #2617 and a set of broken addresses. Every
direct_ipand wildcard on master matches the new format, so existing entries do not start failing. The manifest image builds and runs with the dependency versions bumped in #2615 and #2616.Token stats: 63,872,373 tokens, $24.61
169 requests, 0 subagents. Cost at API list prices: claude-opus-5-5 $24.61