Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce better type checking #64

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

samfry13
Copy link
Contributor

@samfry13 samfry13 commented Jul 27, 2024

This PR adds a few things related to typescript types:

  • Adds prop types to any component that accepted props
  • Updated the newsletters content collection variable name to match the directory name. They previously didn't match, which meant that the zod schema was never being run on the newsletter frontmatter.
  • Adds tests to make sure newsletters are generated with the proper metadata
  • Adds title check to newsletters to make sure they follow This Month in Ladybird - <month> <year>
  • Adds a type check step to CI

@samfry13 samfry13 force-pushed the sfry/update-types branch 2 times, most recently from 699a998 to 4a89a1c Compare July 27, 2024 22:52
src/content/config.ts Outdated Show resolved Hide resolved
src/pages/posts/[...slug].astro Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants