Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: hamburger menu #65

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Cauatn
Copy link
Contributor

@Cauatn Cauatn commented Jul 31, 2024

image

image

Closes (#6 )

@AtkinsSJ
Copy link
Member

AtkinsSJ commented Aug 1, 2024

"Hamburger" is still misspelled.

@Cauatn Cauatn changed the title feat: hamburguer menu feat: hamburger menu Aug 1, 2024
@Mafrans
Copy link

Mafrans commented Aug 13, 2024

Perhaps a nitpick, but the icon could be slightly smaller, 36x36 is very large for an icon. My suggestion would be to reduce its size to 24x24 and place it in a 36x36 or 48x48 rounded box (perhaps transparent with a hover effect?) which acts as its new bounding area.
image

@Cauatn
Copy link
Contributor Author

Cauatn commented Aug 18, 2024

Perhaps a nitpick, but the icon could be slightly smaller, 36x36 is very large for an icon.

@Mafrans It's a nice change, but some discutions on the discord suggests that the project know is passing into a redesign by some company that they hired. Gonna re-size the icon anymay but it's hard to tell if the change is gonna pass.

@ADKaster
Copy link
Member

@Cauatn you've misunderstood the conversations. The design artifacts already exist, as the company was hired prior to the launch of the non-profit

@Cauatn
Copy link
Contributor Author

Cauatn commented Aug 19, 2024

Oh, ok! Sorry for giving the wrong information then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants