Skip to content

Commit

Permalink
Meta: Use release builds as the basis for Sanitizer builds
Browse files Browse the repository at this point in the history
LLVM recommends compiling with at least -O1 to have decent performance
with sanitizers enabled. Indeed, this improves CI performance of LibWeb
tests as follows:

    GCC on Linux:   160.61s to 119.68s (40.93s faster)
    Clang on Linux:  65.56s to  55.64s ( 9.92s faster)
  • Loading branch information
trflynn89 authored and awesomekling committed Oct 26, 2024
1 parent ff3d78f commit 6cd224b
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
4 changes: 2 additions & 2 deletions CMakePresets.json
Original file line number Diff line number Diff line change
Expand Up @@ -100,9 +100,9 @@
},
{
"name": "Sanitizer",
"inherits": "Debug",
"inherits": "default",
"displayName": "Sanitizer Config",
"description": "Debug build using Sanitizers",
"description": "Sanitizer build using Ninja generator",
"binaryDir": "${fileDir}/Build/ladybird-sanitizers",
"cacheVariables": {
"ENABLE_UNDEFINED_SANITIZER": "ON",
Expand Down
1 change: 1 addition & 0 deletions Meta/CMake/vcpkg/sanitizer-triplets/sanitizer.cmake
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
set(VCPKG_BUILD_TYPE release)
set(VCPKG_LIBRARY_LINKAGE static)

set(VCPKG_C_FLAGS "")
Expand Down

0 comments on commit 6cd224b

Please sign in to comment.