Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImageDecoder+LibGfx: collate decoded bitmaps before sending over IPC #1435

Merged
merged 1 commit into from
Oct 2, 2024

Commits on Sep 25, 2024

  1. ImageDecoder+LibGfx: Collate decoded bitmaps before sending over IPC

    There is an issue where gifs with many frames cannot be loaded, as each
    bitmap is sent over IPC using a separate file descriptor, and there is
    limit on the maximum number of descriptors per IPC message. Thus, trying
    to load gifs with more than 64 frames (the current limit) causes the
    image decoder process to die.
    
    This commit introduces the BitmapSequence class, which is a thin wrapper
    around the type Vector<Optional<NonnullRefPtr<Gfx::Bitmap>>> and
    provides an IPC encode/decode routine that collates all bitmap data into
    a single buffer so that only a single file descriptor is required per
    IPC transfer, even if multiple frames are being sent.
    zack466 committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    99af66f View commit details
    Browse the repository at this point in the history