Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LibWeb: Always flush character insertions before exiting HTML parser #1469

Merged
merged 1 commit into from
Sep 21, 2024
+8 −1
Merged

LibWeb: Always flush character insertions before exiting HTML parser #1469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Tests/LibWeb/Text/expected/HTML/document-write-flush-character-insertions.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
PASS
6 changes: 6 additions & 0 deletions Tests/LibWeb/Text/input/HTML/document-write-flush-character-insertions.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
<script src="../include.js"></script>
<script>
test(() => {
document.write("PASS");
});
</script>
2 changes: 1 addition & 1 deletion Userland/Libraries/LibWeb/HTML/Parser/HTMLParser.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ void HTMLParser::run(HTMLTokenizer::StopAtInsertionPoint stop_at_insertion_point
for (;;) {
// FIXME: Find a better way to say that we come from Document::close() and want to process EOF.
if (!m_tokenizer.is_eof_inserted() && m_tokenizer.is_insertion_point_reached())
return;
break;

auto optional_token = m_tokenizer.next_token(stop_at_insertion_point);
if (!optional_token.has_value())
Expand Down
Loading