fix: replace crashing graphar import with raw yaml parser - #11
Merged
Conversation
adsharma
reviewed
Aug 13, 2026
Collaborator
|
I no longer see |
Contributor
Author
|
I thought you wanted me to just do a lazy import, should I make it use the raw parsing if there is an exception instead? (should I use the raw parsing as fallback) Edit: I'm commiting with the fallback |
adsharma
reviewed
Aug 13, 2026
Contributor
Author
|
I've gone ahead and added a unit test, lmk if you want me to change/add anything |
adsharma
force-pushed
the
fix-graphar-import
branch
from
August 13, 2026 20:25
a52d70e to
60b9c76
Compare
adsharma
force-pushed
the
fix-graphar-import
branch
from
August 13, 2026 20:27
60b9c76 to
14d3717
Compare
Collaborator
|
Perhaps strengthen the test by adding a simple graphar example and verifying the data matches? |
Contributor
Author
|
okay, I'll do it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to LadybugDB/ladybug#17
This replaces the crashing
grapharC++ library import with a pure-Python raw YAML adapter class (YamlGraphInfo).This bypasses the current PyArrow manylinux linking crash and unblocks the script so the DuckDB CSR conversion and Cypher generation can be used today, while we wait on the longer-term zero-copy optimizations.