Skip to content

Test with a real GraphAr dir - #17

Open
rahul21-7 wants to merge 2 commits into
Ladybug-Memory:mainfrom
rahul21-7:enhance-graph-test
Open

Test with a real GraphAr dir#17
rahul21-7 wants to merge 2 commits into
Ladybug-Memory:mainfrom
rahul21-7:enhance-graph-test

Conversation

@rahul21-7

Copy link
Copy Markdown
Contributor

Following up on the merge in previous PR strengthened the fallback parser test to mock a real GraphAr directory structure and verify the data mapping logic.

@adsharma adsharma changed the title made changes to the test Test with a real GraphAr dir Aug 19, 2026
@adsharma

Copy link
Copy Markdown
Collaborator

Were you able to validate the test case with any graphar tooling?

@rahul21-7

Copy link
Copy Markdown
Contributor Author

I actually just manually constructed this as a minimal mock based on the specific fields our YamlGraphInfo fallback parser reads. Because it's minimal, it likely wouldn't pass strict validation through the official graphar tooling (it's missing fields like version, chunk_size, and property_groups).

Since we're just testing the fallback parser's mapping logic, is the minimal mock fine? Or would you prefer I pad it out with the rest of the required GraphAr schema so it's fully compliant with the official tooling?

@adsharma

Copy link
Copy Markdown
Collaborator

Prefer padding out since this is testing compatibility

@rahul21-7

Copy link
Copy Markdown
Contributor Author

I padded the mock files with the required fields (version, chunk_size, property_groups, adj_lists, etc.) to match the strict GraphAr schema. I tried to validate them locally, but the official graphar python package fails to build its C++ wheels on my Windows environment. Since the fields are pulled directly from the spec, they should be fully compliant, but let me know if you spot anything I missed!

@adsharma

Copy link
Copy Markdown
Collaborator

Why not test with a Java version of graphar (which is hopefully better supported) or test with another database that imports graphar importing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants