fix(simd): build NEON lane-mask weights without brace init on MSVC - #819
Merged
Conversation
MSVC ARM64 maps NEON vector types (uint8x8_t, uint16x8_t, uint32x4_t) to
the __n64/__n128 intrinsic types, which cannot be initialized with scalar
brace lists (C2078: too many initializers). Build the {1,2,4,...} lane
weights from bit patterns via vcreate_u8/vcreate_u16/vcreate_u32 +
vcombine instead, which is portable across GCC/Clang/MSVC.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Recent SIMD filter kernels (
70f8828c5,d187dd03c) break Windows ARM64 builds. MSVC fails compilingsrc/function/simd_filter_neon.cpp:Root cause
MSVC ARM64 maps the NEON vector types (
uint8x8_t,uint16x8_t,uint32x4_t, ...) to the intrinsic__n64/__n128types, which cannot be initialized with scalar brace lists (same known issue as xtensor-stack/xsimd#611). The lane-mask weights{1, 2, 4, 8, ...}intoLaneMaskwere constructed with= {...}initializers.Fix
Build the weights from bit patterns using
vcreate_u8/vcreate_u16/vcreate_u32+vcombine, which is portable across GCC, Clang, and MSVC:uint8x8_t:vcreate_u8(0x8040201008040201ULL)→{1,2,4,8,16,32,64,128}uint16x8_t:vcombine_u16(vcreate_u16(...), vcreate_u16(...))→{1,...,128}uint32x4_t:vcombine_u32(vcreate_u32(...), vcreate_u32(...))→{1,2,4,8}Verification
SIMDFilterTest.*(4 tests) pass locally on ARM64.ci-workflow.ymlwithplatform=windows— Build and Test steps pass on the Windows ARM64 runner.