Merged
Conversation
Collaborator
|
LGTM, small rewording suggested to fit better with other listed features |
dwRchyngqxs
reviewed
Mar 16, 2026
docs/c_compiler.md
Outdated
| * the `void` type is not tested explicitly, but it appears in some helper functions in the test cases, so your compiler cannot break when it encounters this keyword | ||
| * the `static` keyword | ||
| * standard library support (e.g. `printf(...)` from `<stdio.h>` header) | ||
| * heap-allocation: follows from "stdlib support", system call functions (typically used in heap-memory allocation) will also not be tested |
Collaborator
There was a problem hiding this comment.
Suggested change
| * heap-allocation: follows from "stdlib support", system call functions (typically used in heap-memory allocation) will also not be tested | |
| * heap-allocation: follows from "standard library support", system call functions (typically used in heap-memory allocation) will also not be tested |
Collaborator
|
To speed things up, I've pushed the version which we seem to agree on:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
just adding a line to explicitly clarify that we are not testing heap allocation, since I got 2 questions on it.
Closes #56