Register Password to be min 8 to match ResetPassword and laravel default #4916
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Laravel 10 and Backpack 6 is very near, so I thought I revive this old issue. Only bump the password min from 6 to 8, nothing about Password::defaults() or how the config rules should be like, be it in config file or ServiceProvider
WHY
BEFORE - What was wrong? What was happening before this PR?
Backpack Register password minimum is 6, but ResetPassword in Backpack and Laravel Default is Min 8. This is not consistent. NIST also recommends password to be minimum length 8
AFTER - What is happening after this PR?
Backpack Register Controller password minimum to be min length 8 to match Reset Password and Laravel Default
HOW
How did you achieve that, in technical terms?
Update the validation Rule
Is it a breaking change?
Well Laravel 10 is and backpack 6 is coming, I doubt new users registering will ever realise min password length has increased by 2 characters too.
How can we test the before & after?
Try and register with a password less than 8 characters?