Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] linkTarget column helper #5391

Merged
merged 3 commits into from
Dec 30, 2023
Merged

[FEATURE] linkTarget column helper #5391

merged 3 commits into from
Dec 30, 2023

Conversation

promatik
Copy link
Contributor

WHY

This will allow developers to change the linkTo target.

CRUD::column('category')
    ->linkTo('category.show')
    ->linkTarget('_blank');

Is it a breaking change?

No 👌

@karandatwani92
Copy link
Contributor

Hey @promatik

I have tested linkTarget(). It works flawlessly. You can merge it.

BUT while testing I found a case where linkTo() throws an error.(Not related with this PR)

To reproduce this - In the demo, create a pet without a passport.

@karandatwani92
Copy link
Contributor

And a gentle reminder for the documentation

promatik and others added 2 commits December 30, 2023 02:13
# Conflicts:
#	src/macros.php
[ci skip] [skip ci]
@promatik promatik merged commit bae18d4 into main Dec 30, 2023
3 checks passed
@promatik promatik deleted the column-link-target branch December 30, 2023 02:34
@promatik
Copy link
Contributor Author

BUT while testing I found a case where linkTo() throws an error.(Not related with this PR)

Fixed that one here; #5412

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

4 participants