Novos sprites para a Black Blade do Mantis Forense.#118
Open
OttavioBasques wants to merge 3 commits intoLaryNevesPR:EE-Andromedafrom
Open
Novos sprites para a Black Blade do Mantis Forense.#118OttavioBasques wants to merge 3 commits intoLaryNevesPR:EE-Andromedafrom
OttavioBasques wants to merge 3 commits intoLaryNevesPR:EE-Andromedafrom
Conversation
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
⏰ Context from checks skipped due to timeout of 90000ms (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
RSI Diff Bot; head commit 5de6fd2 merging into 6337dae Resources/Textures/_Andromeda/Objects/Weapons/Melee/BlackBlade/black_blade.rsi
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (1)
Resources/Locale/pt-BR/Entities/Objects/Weapons/Melee/sword.ftl (1)
12-13: Sugestão de refinamento na descrição para maior fidelidade ao original.A descrição atual está boa, mas não reflete o termo “incessantly” nem “wielder” do original. Para manter a nuance, proponho:
-ent-MantisBlackBlade = Lâmina Negra - .desc = Uma enorme lâmina tão escura quanto o cosmos profundo. Ela sussurra em sua mente. +ent-MantisBlackBlade = Lâmina Negra + .desc = Uma enorme lâmina tão escura quanto o cosmos profundo, sussurrando incessantemente ao seu portador.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (3)
Resources/Textures/_Andromeda/Objects/Weapons/Melee/BlackBlade/black_blade.rsi/icon.pngis excluded by!**/*.pngResources/Textures/_Andromeda/Objects/Weapons/Melee/BlackBlade/black_blade.rsi/inhand-left.pngis excluded by!**/*.pngResources/Textures/_Andromeda/Objects/Weapons/Melee/BlackBlade/black_blade.rsi/inhand-right.pngis excluded by!**/*.png
📒 Files selected for processing (4)
Resources/Locale/pt-BR/Entities/Objects/Weapons/Melee/sword.ftl(1 hunks)Resources/Locale/pt-BR/abilities/psionic.ftl(1 hunks)Resources/Prototypes/Psionics/mantisPowers.yml(3 hunks)Resources/Textures/_Andromeda/Objects/Weapons/Melee/BlackBlade/black_blade.rsi/meta.json(1 hunks)
🔇 Additional comments (3)
Resources/Prototypes/Psionics/mantisPowers.yml (3)
21-22: As referências aos novos paths de sprite parecem corretas e espelham a estrutura do recursoblack_blade.rsi. Nenhuma ação adicional necessária.Also applies to: 28-29, 46-47
31-31: As strings de fala e descrição do item estão consistentes com o objetivo visual e narrativo. Sem ajustes críticos.Also applies to: 42-42
82-83: Configurações derangeevolumedo som estão de acordo com o PR (diminuindo alcance/volume). Verifique em jogo se o resultado sonoro está adequado.
Comment on lines
+11
to
+20
| "name": "icon", | ||
| "delays": [ | ||
| [ | ||
| 0.3, | ||
| 0, | ||
| 0, | ||
| 0 | ||
| ] | ||
| ] | ||
| }, |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Configuração de ‘delays’ inconsistente no estado “icon”.
O array de delays para o estado “icon” está definindo quatro entradas (0.3, 0, 0, 0) sem especificar directions, o que pode causar erro de parsing da animação. Geralmente um ícone não é direcional e deve usar apenas um valor de delay por frame.
{
"name": "icon",
- "delays": [
- [
- 0.3,
- 0,
- 0,
- 0
- ]
- ]
+ "directions": 1,
+ "delays": [
+ [ 0.3 ]
+ ]
}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| "name": "icon", | |
| "delays": [ | |
| [ | |
| 0.3, | |
| 0, | |
| 0, | |
| 0 | |
| ] | |
| ] | |
| }, | |
| "name": "icon", | |
| "directions": 1, | |
| "delays": [ | |
| [ 0.3 ] | |
| ] | |
| }, |
🤖 Prompt for AI Agents
In
Resources/Textures/_Andromeda/Objects/Weapons/Melee/BlackBlade/black_blade.rsi/meta.json
around lines 11 to 20, the 'delays' array for the "icon" state incorrectly
contains four delay values without specifying directions, which can cause
animation parsing errors. To fix this, simplify the 'delays' array to include
only a single delay value per frame since the icon is non-directional, removing
the unnecessary multiple entries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Descrição
Eu fiz novos sprites para a Black Blade do Mantis Forense, substituindo as sprites da Cult Blade que ela usa atualmente.
Os novos sprites são inspirados na adaga anti-psiônica que o Mantis Forense possuía antes, ela possui animações similares à Cult Blade.
Os arquivos de tradução foram alterados, adicionando uma tradução para a Black Blade e para a habilidade que invoca ela.
Também foi ajustado o sussuro da espada, deixando-o mais baixo e com um alcance menor.
Mantis.Black.Blade.mp4
Changelog
🆑
Summary by CodeRabbit
Novos Recursos
Ajustes