Skip to content

fix: ensure program exits properly on error #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: ensure program exits properly on error #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions environment/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
use colored::*;
use std::io::{self, Write};

pub fn info(msg: &str) {
println!("{} {}", "[xtask]".green().bold(), msg);
Expand Down Expand Up @@ -202,6 +203,7 @@ pub fn install_env(env: &str) {
error(
"nvidia-smi not found. Please make sure you have an NVIDIA GPU and drivers installed.",
);
return;
}

println!();
Expand All @@ -210,9 +212,20 @@ pub fn install_env(env: &str) {
);
}
"OpenCL" => {
info(
warning(
"The current automatic installation script only supports OpenCL installation for Intel CPU on Windows or Ubuntu systems.",
);
warning("type 'y' to continue, or any other key to exit.");
let mut input = String::new();
io::stdout().flush().unwrap();
io::stdin()
.read_line(&mut input)
.expect("Failed to read input");
if input.trim().to_lowercase() != "y" {
info("Exiting OpenCL installation.");
return;
}

info("Checking if OpenCL is already installed...");
println!();

Expand Down Expand Up @@ -257,9 +270,11 @@ pub fn install_env(env: &str) {
}
} else {
error("Failed to parse the number of platforms.");
return;
}
} else {
error("Failed to find 'Number of platforms' in clinfo output.");
return;
}
}
#[cfg(not(target_os = "windows"))]
Expand All @@ -279,7 +294,7 @@ pub fn install_env(env: &str) {
info("Installing clinfo tool...");
let install_status = std::process::Command::new("sh")
.arg("-c")
.arg("sudo apt update && sudo apt install opencl-headers ocl-icd-opencl-dev -y")
.arg("sudo apt update && sudo apt install clinfo -y")
.status();

if let Err(e) = install_status {
Expand Down Expand Up @@ -313,9 +328,11 @@ pub fn install_env(env: &str) {
}
} else {
error("Failed to parse the number of platforms.");
return;
}
} else {
error("Failed to find 'Number of platforms' in clinfo output.");
return;
}
}

Expand Down