Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix report, format indent, move api #428

Closed
wants to merge 7 commits into from

Conversation

Lumine1909
Copy link
Contributor

之前的report 版本不对 会显示/ver下面的版本diff而不是具体内容
修改了leaves所有内容的缩进 不敢动其他的怕上游更新炸掉
部分api 移出了patch 以后更好维护一些

@Lumine1909
Copy link
Contributor Author

另外改之前忘记rebase了 所以可能有点乱(悲

@Bluemangoo
Copy link
Member

新开一个分支cherrypick过来,或者reset搁置同步解除搁置。

@Bluemangoo
Copy link
Member

而且怎么在indent的pr里面修bug,indent另开。

@Bluemangoo
Copy link
Member

这么大的重构也别塞在一起啊,这是3个pr,别合在一起,后面找很难找的。

@Lumine1909
Copy link
Contributor Author

这么大的重构也别塞在一起啊,这是3个pr,别合在一起,后面找很难找的。

那我先把这个关了?

@Bluemangoo
Copy link
Member

嗯,你慢慢拆分吧。indent那个是有概率要部分回滚的,重构那个也要慢慢review,这个bugfix倒是一个commit一下就合了。

@Lumine1909 Lumine1909 closed this Mar 12, 2025
@Lumine1909 Lumine1909 deleted the dev/format-indent branch March 24, 2025 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants