Add developer quickstart guide with Docker Compose and Testnet integration#317
Open
vicky4196 wants to merge 1 commit into
Open
Add developer quickstart guide with Docker Compose and Testnet integration#317vicky4196 wants to merge 1 commit into
vicky4196 wants to merge 1 commit into
Conversation
…ation - Add docs/developer_quickstart.md with prerequisites, setup steps, and troubleshooting - Add make run-testnet target for Testnet pipeline execution - Add make check-env target for environment validation - Add scripts/check_env.py for human-readable env var validation - Add tests/test_check_env.py for check-env CI verification - Add CI steps to verify check-env behavior closes Ledger-Lenz#266
|
@vicky4196 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
please resolve confli cts from your end |
Contributor
|
please stillwaiting on you to resolve conflict |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Developer Environment Quickstart Guide Implementation
Summary
This PR implements the Developer Environment Quickstart Guide as requested in issue #266. It provides a cohesive zero-to-hero guide for new contributors, covering the complete setup process from cloning the repository to running the pipeline against Stellar Testnet.
Changes
1. New Documentation:
docs/developer_quickstart.mdA comprehensive quickstart guide that covers:
.envfiles.envwith required variablesmake check-envmake run-testnetusagemake installWATCHED_ASSET_PAIRSerror2. New Makefile Target:
make run-testnetAdded to
Makefile:This target:
STELLAR_NETWORK=TESTNETto target the test networkscripts/stream.py) with Testnet defaults3. New Makefile Target:
make check-envAdded to
Makefile:Along with the new script
scripts/check_env.pythat validates required environment variables and produces clear, human-readable error messages (not Python tracebacks) for any missing configuration.4. CI Tests for
make check-envAdded to
.github/workflows/ci.yml:5. Unit Tests:
tests/test_check_env.pyTests verify:
check-envexits 0 with all required env vars setcheck-envexits non-zero with specific missing var and expected error messagecheck-envreports multiple missing vars in one runSecurity Considerations
The quickstart guide includes prominent warnings:
.envfiles to version controlValidation
All tests pass:
closes #266