This repository has been archived by the owner on Jan 23, 2025. It is now read-only.
forked from dropbox/djinni
-
Notifications
You must be signed in to change notification settings - Fork 15
Rebased master #15
Open
KhalilBellakrid
wants to merge
142
commits into
LedgerHQ:master
Choose a base branch
from
KhalilBellakrid:rebased-master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Rebased master #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Generate an XCode like bridging header. Generates also the version number and name variable. * Add new generated headers. * Changes naming accorging to comments. * Update generated variable names.
* Got a basic version of constexpr in headers working * got enum values to work as well * can't do enums because interface headers forward declare so you can't set it there. So only primitives allowed * fixing const enums in obj-c, which apparently never worked to begin with
Separate constant_enum to constant_enum.djinni, to exclude it from common.djinni, so that it wouldn’t be picked up by Python in python branch. Otherwise it causes failure in python branch since constant enum feature is not implemented for Python.
* rename destroy to __destroy * update generated-src in test-suite * use _djinni_destroy * _djinni_private_destroy
* Added: + brace matcher + highlight for keywords * Revert license * Fix nullability bug * Update version
* Provides compatibility for clang Without this, clang will treat it as an error that `jniDefaultSetPendingFromCurrent` could potentially throw an uncaught exception. * Update djinni_support.cpp typo * Renamed function and added comment for rationale. * Whitespace for proper alignment * Check for Duplicate Output Paths This adds some simple logic to check whether files are set to overwrite each other. This is especially helpful for newcomers who are confused when the default settings cause this issue. * Revert "Check for Duplicate Output Paths" This reverts commit 06441f4.
* Check for Duplicate Output Paths This adds some simple logic to check whether files are set to overwrite each other. This is especially helpful for newcomers who are confused when the default settings cause this issue. * Simplified Implementation I realized that the existing codebase actually already does this for files created by the same generator. This change makes it apply to all generators, preventing cross-language overwriting.
* Merge mrdomino's Java interface change with a more recent version of the repo. * Make generating interfaces instead of abstract classes optional. * Allow generation of Java interfaces when the Djinni interface is a +c interface and when the Djinni interface includes constants. * Also omit "public" from constants in a Java interface. * Revert "Also omit "public" from constants in a Java interface." This reverts commit a4245b3. * Omit "public" from constants in a Java interface. * If Java interfaces were requested, generate them regardless of whether the interfaces include static methods. * Keep CppProxy private if not generating interfaces. * Change the java tests' target java version to 1.8. * Place static natic methods in an inner class. * Remove the StaticNative class and just use CppProxy. * Minor edits. * Don't use --java-generate-interfaces in the yaml test, in order to exercise the code that runs when --java-generate-interfaces isn't used. * Revert "Don't use --java-generate-interfaces in the yaml test, in order to exercise the code that runs when --java-generate-interfaces isn't used." This reverts commit cd86c27. * Build the example Android project with Java 8.
When the CDPATH environment variable is set, the cd command prints the path of the directory to stdout. Redirect that output to /dev/null to avoid it being mistakenly included in the base_dir variable, which then causes cryptic errors.
* Implement comments support, tests and readme documentation * improve code comments and documents comments parser when the two types of comments are one after the other * improve tests
This reverts commit 0ee3da6.
dropbox#413) * Add cast to objective C convenience initializers to prevent naming collisions * Regenerate the generated for example and test suite
README instructions do not generate the files they say they will generate, fix the djinni command called so that they match up.
dropbox#405) * Implement basic automatic attachment/detachment of c++ threads to JVM. No side effects if not enabled Compile with -DEXPERIMENTAL_AUTO_CPP_THREAD_ATTACH to enable Requires a compiler with C++11 support Borrows code/idea from dropbox#372 (comment) * Place assignment outside of define.
This reverts commit fde1163.
- Adding global namespace scope to DJINNI_ASSERT to prevent conflict with local namespaces. - Add <memory> include to reference shared_ptr. - Use temporary variable in djinni_support.hpp to avoid compiler segfault.
Calling Ref to newly created objects prevent him to being garbace collected forever.
This should simplify usages of library and avoid filename collisions.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.