antus/p08 #346
antus/p08 #346
Conversation
…en testing kernel functions in development
…can send key of 0000 to recover a corrupted param block.
…ither syntax worked for both platforms
…ce type, xpro gt with p04 force 1x
… this code entirely?
…cific hardware, use detected flash size instead of hard coded size to validate write operations
…16263494. P59a hybrid OSID 12590777.
|
@LegacyNsfw I think this is ready to move to develop, and create a RC build and ask for public testing. What do you think? |
…t being worked on by multiple authors
| return PcmType.P05; | ||
| } | ||
|
|
||
| this.logger.AddDebugMessage("Trying P12 1Mb"); | ||
| this.logger.AddDebugMessage("Trying P12 1024MiB"); |
There was a problem hiding this comment.
just having a look through here and noticed that a few of these changed by a factor of 1024. Ex: from 1MiB to 1024_M_iB.
There was a problem hiding this comment.
Yep. The suffix meaning MiB wasn't consistent through the app. So I researched what is the most technically correct answer. And I found this: https://cseducators.stackexchange.com/questions/4425/should-i-teach-that-1-kb-1024-bytes-or-1000-bytes
I had to agree with this answer and decided to standardize on the official - even if they are not the most common - si terminology.
"You should teach them it's messed up beyond repair, and it's their generation's job to teach the next generation to use the silly-sounding standard prefixes, so that when they finally retire (and the current old-timers are more permanently removed from the argument), there can finally be a consensus."
Note that this pull request has been superseded by PcmHammer#2
There was a problem hiding this comment.
I dont think I was clear, 1mb is 1024KiB, not 1024MiB. Unless this pcm has a gigabyte of storage?
There was a problem hiding this comment.
Hahaha gotcha. I'll update the WIP branch on the other repo.
Just creating this PR to look at the diffs for now.