Fixes #1
Open
Fixes #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alfito-meli
approved these changes
May 6, 2021
rdiaz-meli
approved these changes
May 7, 2021
glara
approved these changes
May 7, 2021
brutalchrist
approved these changes
May 7, 2021
javierseixas
approved these changes
May 7, 2021
Zannisdf
approved these changes
May 7, 2021
|
LBQEABX |
dochoaj-meli
suggested changes
May 7, 2021
| end | ||
|
|
||
| default_response_tag = soap_config.camelize_wsdl ? 'Response' : '_response' | ||
| default_response_tag = 'Response' |
There was a problem hiding this comment.
Creo que esto debería estar freeze o ser un sym, si no se crean objetos en memoria que el GC de ruby va a tener que salir a allocar en tiempo de request.
despinozac
suggested changes
May 7, 2021
| end | ||
| xml.tag! "soap:Body" do | ||
| xml.tag! "tns:#{@action_spec[:response_tag]}" do | ||
| xml.tag! "SOAP-ENV:Body" do |
There was a problem hiding this comment.
Estamos exponiendo el Body del tag SOAP-ENV y esto pudiera ofender al tag por hacer Body Shamming
|
La rama |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Estos fixes solo se preocupan de mantener la comunicación entre el cliente SOAP de un WSDL viejo y el servicio en Rails. No entregan un WSDL Válido.
Es decir, hace que se reconozca un request desde un cliente y que el response sea un XML válido