Fix vanish-granted flight persisting after reappear, quit and relog#93
Open
MiddleXen wants to merge 3 commits into
Open
Fix vanish-granted flight persisting after reappear, quit and relog#93MiddleXen wants to merge 3 commits into
MiddleXen wants to merge 3 commits into
Conversation
Reset vanish flight for player on join to prevent persistence.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug where flight granted by vanish could persist after the player was no longer invisible.
Problem
In the current version, flight reset only happens inside
showPlayer()when using/sv off:setAllowFlight(false)is called,setFlying(false)is missingReappearOnQuitauto-unvanishes the player on disconnectSolution
VisibilityChanger.resetVanishFlight()with shared logicshowPlayer(),JoinListener(non-vanished join), andQuitListener(auto-reappear on quit)allowFlightandflying, respectingsv.keepflyand gamemode checksChanged files
VisibilityChanger.javaJoinListener.javaQuitListener.java