Skip to content

feat(ci): add strip_prefix input to S3 upload workflow for customizab…#145

Merged
guimoreirar merged 1 commit intomainfrom
s3/strip
Mar 13, 2026
Merged

feat(ci): add strip_prefix input to S3 upload workflow for customizab…#145
guimoreirar merged 1 commit intomainfrom
s3/strip

Conversation

@guimoreirar
Copy link
Member

@guimoreirar guimoreirar commented Mar 13, 2026

…le file path handling

Lerian

GitHub Actions Shared Workflows


Description

Type of Change

  • feat: New workflow or new input/output/step in an existing workflow
  • fix: Bug fix in a workflow (incorrect behavior, broken step, wrong condition)
  • perf: Performance improvement (e.g. caching, parallelism, reduced steps)
  • refactor: Internal restructuring with no behavior change
  • docs: Documentation only (README, docs/, inline comments)
  • ci: Changes to self-CI (workflows under .github/workflows/ that run on this repo)
  • chore: Dependency bumps, config updates, maintenance
  • test: Adding or updating tests
  • BREAKING CHANGE: Callers must update their configuration after this PR

Breaking Changes

None.

Testing

  • YAML syntax validated locally
  • Triggered a real workflow run on a caller repository using @develop or the beta tag
  • Verified all existing inputs still work with default values
  • Confirmed no secrets or tokens are printed in logs
  • Checked that unrelated workflows are not affected

Caller repo / workflow run:

Related Issues

Closes #

Summary by CodeRabbit

  • New Features
    • Added optional strip_prefix input parameter to S3 upload workflow, enabling users to remove a specified prefix from file paths before uploading. Fully supported in dry-run mode and compatible with both workflow call and dispatch triggers.

@guimoreirar guimoreirar requested a review from a team as a code owner March 13, 2026 18:38
@guimoreirar guimoreirar merged commit 9caaf4c into main Mar 13, 2026
1 check was pending
@coderabbitai
Copy link

coderabbitai bot commented Mar 13, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 6cc2ecf1-f50d-43bf-a685-340768fdea22

📥 Commits

Reviewing files that changed from the base of the PR and between 73e2f69 and 308fe4c.

📒 Files selected for processing (1)
  • .github/workflows/s3-upload.yml

Walkthrough

Adds optional strip_prefix parameter to the S3 upload workflow that removes a specified prefix from file paths before uploading. The parameter propagates through dry-run and actual upload steps, adjusting destination path computation when a prefix is configured.

Changes

Cohort / File(s) Summary
Workflow Input Addition
.github/workflows/s3-upload.yml
Added strip_prefix input parameter (string, default: '') to both workflow_call and workflow_dispatch triggers. Exposes STRIP_PREFIX environment variable and updates dry-run and upload logic to strip the configured prefix from source file paths when computing S3 destination paths.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch s3/strip
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant