Skip to content

Develop#76

Merged
guimoreirar merged 5 commits intomainfrom
develop
Jan 21, 2026
Merged

Develop#76
guimoreirar merged 5 commits intomainfrom
develop

Conversation

@guimoreirar
Copy link
Copy Markdown
Member

Description

Type of Change

  • feat: New feature or workflow
  • fix: Bug fix
  • docs: Documentation update
  • refactor: Code refactoring
  • perf: Performance improvement
  • test: Adding or updating tests
  • ci: CI/CD configuration changes
  • chore: Maintenance tasks
  • BREAKING CHANGE: Breaking change (requires major version bump)

Affected Workflows

  • GitOps Update
  • API Dog E2E Tests
  • PR Security Scan
  • Release Workflow
  • Other (specify): _______________

Changes Made

Breaking Changes

None / Describe breaking changes here

Testing

  • Tested locally
  • Tested in development environment
  • Tested with example repository: _______________
  • All existing workflows still work

Checklist

  • Code follows conventional commit format
  • Documentation updated (if applicable)
  • Examples updated (if applicable)
  • No hardcoded secrets or sensitive data
  • Backward compatible (or breaking changes documented)
  • Self-review completed
  • Comments added for complex logic

Related Issues

Closes #
Related to #

Additional Notes

@guimoreirar guimoreirar self-assigned this Jan 21, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Jan 21, 2026

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request adds helm_dispatch_on_rc and helm_dispatch_on_beta boolean inputs plus a helm_values_key_mappings string input to the build workflow, gating Helm dispatch to releases or enabled RC/beta tags. It propagates values_key_mappings into the dispatch-helm workflow, which resolves per-component values_key (fallback to component name) and includes values_key in the components payload. The helm-update-chart workflow now accepts a values_key per component (create_secret_template(comp_name, values_key)) and uses it when generating values.yaml, secrets, and configmap entries. The gitops update workflow now imports a GPG key and signs commits rather than setting git user config.

Sequence Diagram(s)

sequenceDiagram
    participant Trigger as Developer / CI trigger
    participant Build as .github/workflows/build.yml
    participant Dispatch as .github/workflows/dispatch-helm.yml
    participant HelmUpdate as .github/workflows/helm-update-chart.yml
    participant GitOps as gitops repo (commit & push)

    Trigger->>Build: start (includes helm_dispatch_on_rc/beta, helm_values_key_mappings)
    Build->>Build: evaluate helm dispatch condition
    alt conditions met
        Build->>Dispatch: dispatch-helm (pass values_key_mappings, components)
        Dispatch->>Dispatch: resolve each component.values_key (mapping or fallback)
        Dispatch->>HelmUpdate: post components payload (name, version, env_vars, values_key)
        HelmUpdate->>HelmUpdate: generate templates using values_key (create_secret_template(name, values_key))
        HelmUpdate->>GitOps: commit updated charts/values (signed)
        GitOps->>GitOps: Import GPG key & sign commit
    else not met
        Build-->>Trigger: skip helm dispatch
    end
Loading
🚥 Pre-merge checks | ❌ 2
❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description is incomplete; all required sections lack content - no actual description provided, type of change unchecked, affected workflows unmarked, changes not listed, testing not documented. Complete all template sections: add description summary, check the 'ci' change type, mark affected workflows (GitOps Update and Release Workflow), list the three specific changes, and confirm testing.
Title check ❓ Inconclusive The title 'Develop' is vague and generic, providing no meaningful information about the actual changes (Helm dispatch conditions and GPG signing). Update the title to specifically describe the main changes, such as 'Add conditional Helm dispatch for rc/beta tags and GPG signing for GitOps commits'.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In @.github/workflows/gitops-update.yml:
- Around line 383-394: The Import GPG key step uses
crazy-max/ghaction-import-gpg@v6 and references four secrets
(LERIAN_CI_CD_USER_GPG_KEY, LERIAN_CI_CD_USER_GPG_KEY_PASSWORD,
LERIAN_CI_CD_USER_NAME, LERIAN_CI_CD_USER_EMAIL) that are not declared for
callers; update the workflow_call block to add these four secrets (mark required
as appropriate) so external callers can pass them explicitly, and replace the
action pin `@v6` with the action’s full commit SHA (pin to a specific commit) in
the step named "Import GPG key" to mitigate supply-chain risk.

@guimoreirar guimoreirar merged commit 8234138 into main Jan 21, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant