Conversation
|
Caution Review failedThe pull request is closed. WalkthroughThis pull request adds helm_dispatch_on_rc and helm_dispatch_on_beta boolean inputs plus a helm_values_key_mappings string input to the build workflow, gating Helm dispatch to releases or enabled RC/beta tags. It propagates values_key_mappings into the dispatch-helm workflow, which resolves per-component values_key (fallback to component name) and includes values_key in the components payload. The helm-update-chart workflow now accepts a values_key per component (create_secret_template(comp_name, values_key)) and uses it when generating values.yaml, secrets, and configmap entries. The gitops update workflow now imports a GPG key and signs commits rather than setting git user config. Sequence Diagram(s)sequenceDiagram
participant Trigger as Developer / CI trigger
participant Build as .github/workflows/build.yml
participant Dispatch as .github/workflows/dispatch-helm.yml
participant HelmUpdate as .github/workflows/helm-update-chart.yml
participant GitOps as gitops repo (commit & push)
Trigger->>Build: start (includes helm_dispatch_on_rc/beta, helm_values_key_mappings)
Build->>Build: evaluate helm dispatch condition
alt conditions met
Build->>Dispatch: dispatch-helm (pass values_key_mappings, components)
Dispatch->>Dispatch: resolve each component.values_key (mapping or fallback)
Dispatch->>HelmUpdate: post components payload (name, version, env_vars, values_key)
HelmUpdate->>HelmUpdate: generate templates using values_key (create_secret_template(name, values_key))
HelmUpdate->>GitOps: commit updated charts/values (signed)
GitOps->>GitOps: Import GPG key & sign commit
else not met
Build-->>Trigger: skip helm dispatch
end
🚥 Pre-merge checks | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @.github/workflows/gitops-update.yml:
- Around line 383-394: The Import GPG key step uses
crazy-max/ghaction-import-gpg@v6 and references four secrets
(LERIAN_CI_CD_USER_GPG_KEY, LERIAN_CI_CD_USER_GPG_KEY_PASSWORD,
LERIAN_CI_CD_USER_NAME, LERIAN_CI_CD_USER_EMAIL) that are not declared for
callers; update the workflow_call block to add these four secrets (mark required
as appropriate) so external callers can pass them explicitly, and replace the
action pin `@v6` with the action’s full commit SHA (pin to a specific commit) in
the step named "Import GPG key" to mitigate supply-chain risk.
feat(helm): add values key mapping support for component names
Description
Type of Change
feat: New feature or workflowfix: Bug fixdocs: Documentation updaterefactor: Code refactoringperf: Performance improvementtest: Adding or updating testsci: CI/CD configuration changeschore: Maintenance tasksBREAKING CHANGE: Breaking change (requires major version bump)Affected Workflows
Changes Made
Breaking Changes
None / Describe breaking changes here
Testing
Checklist
Related Issues
Closes #
Related to #
Additional Notes