chore(pipe): add ORAS installation and tagging for latest chart version#1082
chore(pipe): add ORAS installation and tagging for latest chart version#1082guimoreirar merged 3 commits intomainfrom
Conversation
chore: sync main to develop [skip ci]
WalkthroughThe release workflow in Sequence Diagram(s)sequenceDiagram
participant Release as Release event
participant Runner as GitHub Actions runner
participant ORAS as ORAS tool
participant GHCR as GitHub Container Registry
participant Docker as Docker Hub
Release->>Runner: trigger release workflow
Runner->>Runner: install oras (oras-project/setup-oras@v1.2.4)
Runner->>ORAS: authenticate to GHCR (token)
Runner->>ORAS: authenticate to Docker Hub (username/password)
ORAS->>GHCR: copy chart image from vX.Y.Z tag to latest
ORAS->>Docker: copy chart image from vX.Y.Z tag to latest
Runner-->>Release: step complete
🚥 Pre-merge checks | ✅ 1 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
gandalf-at-lerian
left a comment
There was a problem hiding this comment.
LGTM! Clean addition — ORAS cp is the right approach for OCI re-tagging. Conditions are properly scoped to main + new release. Blocking behavior on registry sync is the correct call to keep GHCR and Docker Hub consistent.
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/release.yml:
- Around line 182-183: The second oras cp command is using Docker Hub as the
source but the versioned chart is published only to GHCR; update the source in
the second command so it copies from ghcr.io/lerianstudio/${CHART}:${VERSION} to
registry-1.docker.io/lerianstudio/${CHART}:latest (i.e., change the source
reference in the oras cp that currently starts with
"registry-1.docker.io/lerianstudio/${CHART}:${VERSION}" to
"ghcr.io/lerianstudio/${CHART}:${VERSION}") so the push to Docker Hub pulls the
versioned artifact from GHCR.
- Around line 169-171: Replace the floating tag in the GitHub Actions step named
"Install oras" (uses: oras-project/setup-oras@v1.2.4) with the action pinned to
the full commit SHA for that release (e.g., oras-project/setup-oras@<full-sha>),
and add a trailing comment containing the tag for human clarity (e.g., #
v1.2.4); update the uses line to reference the full SHA instead of `@v1.2.4` to
prevent tag retargeting and preserve supply-chain integrity.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: a6aa2f1e-de19-4d36-ae73-ca4a964ebbad
📒 Files selected for processing (1)
.github/workflows/release.yml
Midaz Pull Request Checklist
Pull Request Type
Checklist
Please check each item after it's completed.
Additional Notes
Obs: Please, always remember to target your PR to develop branch instead of main.