fix(plugin-br-pix-indirect-btg): add WEBHOOK_DEFAULT_URL to outbound configmap#1127
fix(plugin-br-pix-indirect-btg): add WEBHOOK_DEFAULT_URL to outbound configmap#1127gandalf-at-lerian wants to merge 1 commit intodevelopfrom
Conversation
…configmap The outbound worker requires WEBHOOK_DEFAULT_URL as a fallback when entity-specific URLs (e.g. DICT_FUNDS_RECOVERY) are not configured. Without it, the worker panics on startup: panic: WEBHOOK_DEFAULT_URL is required when entity DICT_FUNDS_RECOVERY has no specific URL configured Added to both the configmap template and default values.yaml.
WalkthroughThis change adds a new configuration parameter 🚥 Pre-merge checks | ✅ 1 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. 📝 Coding Plan
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@charts/plugin-br-pix-indirect-btg/templates/outbound/configmap.yaml`:
- Line 93: Normalize the Helm template brace spacing for the WEBHOOK_DEFAULT_URL
entry so it uses a single space after the opening braces and before the closing
braces; update the template expression for WEBHOOK_DEFAULT_URL to "{{
.Values.outbound.configmap.WEBHOOK_DEFAULT_URL | default \"\" | quote }}"
(adjusting only the brace spacing around the existing
.Values.outbound.configmap.WEBHOOK_DEFAULT_URL expression) to satisfy YAMLlint.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 27c04993-4042-47a4-9733-6cb2becb333c
📒 Files selected for processing (2)
charts/plugin-br-pix-indirect-btg/templates/outbound/configmap.yamlcharts/plugin-br-pix-indirect-btg/values.yaml
| # ============================================================================== | ||
| # WARNING: Webhook URLs must be explicitly set in values.yaml or values-<env>.yaml | ||
| # Leaving empty disables external webhook delivery for safety | ||
| WEBHOOK_DEFAULT_URL: {{ .Values.outbound.configmap.WEBHOOK_DEFAULT_URL | default "" | quote }} |
There was a problem hiding this comment.
Fix template brace spacing to satisfy YAMLlint.
Line 93 is currently flagged by YAMLlint (braces) in this PR. Please normalize the template braces on this line to avoid lint failure.
Suggested fix
- WEBHOOK_DEFAULT_URL: {{ .Values.outbound.configmap.WEBHOOK_DEFAULT_URL | default "" | quote }}
+ WEBHOOK_DEFAULT_URL: {{.Values.outbound.configmap.WEBHOOK_DEFAULT_URL | default "" | quote}}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| WEBHOOK_DEFAULT_URL: {{ .Values.outbound.configmap.WEBHOOK_DEFAULT_URL | default "" | quote }} | |
| WEBHOOK_DEFAULT_URL: {{.Values.outbound.configmap.WEBHOOK_DEFAULT_URL | default "" | quote}} |
🧰 Tools
🪛 YAMLlint (1.38.0)
[error] 93-93: too many spaces inside braces
(braces)
[error] 93-93: too many spaces inside braces
(braces)
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@charts/plugin-br-pix-indirect-btg/templates/outbound/configmap.yaml` at line
93, Normalize the Helm template brace spacing for the WEBHOOK_DEFAULT_URL entry
so it uses a single space after the opening braces and before the closing
braces; update the template expression for WEBHOOK_DEFAULT_URL to "{{
.Values.outbound.configmap.WEBHOOK_DEFAULT_URL | default \"\" | quote }}"
(adjusting only the brace spacing around the existing
.Values.outbound.configmap.WEBHOOK_DEFAULT_URL expression) to satisfy YAMLlint.
1 participant
Problem
The outbound worker panics on startup when entity-specific webhook URLs are not configured, because
WEBHOOK_DEFAULT_URLis missing from the configmap template.This causes CrashLoopBackOff in dev environments running
1.5.0-beta.16.Fix
Add
WEBHOOK_DEFAULT_URLto the outbound configmap template and default values.yaml. Defaults to empty string — environments that need it can set it in their gitops values.Related