chore(deps): bump lib-commons to v4.1.0-beta.10#1924
Conversation
Includes fix for Ping response reverting 'pong' → 'healthy' for lib-auth compatibility (#363).
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughThis pull request updates the 🚥 Pre-merge checks | ✅ 1 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. 📝 Coding Plan
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@go.mod`:
- Line 103: You updated the go.mod dependency to
"github.com/LerianStudio/lib-commons/v4 v4.1.0-beta.10" which is a pre-release
with behavior changes; before merging, run full integration tests and verify
health-check endpoints (lib-auth compatibility), MongoDB connections (authSource
default), OTEL pipeline endpoint normalization, and HTTP client insecure-mode
behavior; if any test fails, either revert to the previous stable version or
implement compatibility fixes in the code paths that interact with lib-commons
(search for usages of the lib-commons client/helpers in your repo to locate
where to adjust behavior).
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: a341c23c-17c7-4920-be39-6d786de4c98f
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (1)
go.mod
📊 Unit Test Coverage Report:
|
| Metric | Value |
|---|---|
| Overall Coverage | 87.1% ✅ PASS |
| Threshold | 85% |
Coverage by Package
| Package | Coverage |
|---|---|
github.com/LerianStudio/midaz/v3/components/ledger/internal/adapters/http/in |
86.8% |
Generated by Go PR Analysis workflow
📊 Unit Test Coverage Report:
|
| Metric | Value |
|---|---|
| Overall Coverage | 87.7% ✅ PASS |
| Threshold | 85% |
Coverage by Package
| Package | Coverage |
|---|---|
github.com/LerianStudio/midaz/v3/components/crm/internal/adapters/http/in |
86.2% |
github.com/LerianStudio/midaz/v3/components/crm/internal/adapters/mongodb/alias |
92.1% |
github.com/LerianStudio/midaz/v3/components/crm/internal/adapters/mongodb/holder |
87.1% |
github.com/LerianStudio/midaz/v3/components/crm/internal/services |
95.2% |
Generated by Go PR Analysis workflow
🔒 Security Scan Results —
|
🔒 Security Scan Results —
|
Summary
Bumps
lib-commonsfromv4.1.0-beta.9→v4.1.0-beta.10.What's included in beta.10
"pong"→"healthy"for lib-auth compatibility (#363)AllowInsecureHTTPto internal tenant manager client (#357)authSource=admininbuildMongoURI(#361)Why
The health check endpoint in lib-commons was returning
"pong"while lib-auth expects"healthy". This PR brings Midaz in sync with the correct response.