Skip to content

chore(deps): bump lib-commons to v4.1.0-beta.10#1924

Merged
ClaraTersi merged 2 commits intodevelopfrom
chore/bump-lib-commons-beta10
Mar 19, 2026
Merged

chore(deps): bump lib-commons to v4.1.0-beta.10#1924
ClaraTersi merged 2 commits intodevelopfrom
chore/bump-lib-commons-beta10

Conversation

@gandalf-at-lerian
Copy link

Summary

Bumps lib-commons from v4.1.0-beta.9v4.1.0-beta.10.

What's included in beta.10

  • fix: revert Ping response from "pong""healthy" for lib-auth compatibility (#363)
  • fix: propagate AllowInsecureHTTP to internal tenant manager client (#357)
  • fix(otel): normalize endpoint URL and infer insecure mode from scheme (#362)
  • fix(mongo): default authSource=admin in buildMongoURI (#361)

Why

The health check endpoint in lib-commons was returning "pong" while lib-auth expects "healthy". This PR brings Midaz in sync with the correct response.

Includes fix for Ping response reverting 'pong' → 'healthy'
for lib-auth compatibility (#363).
@gandalf-at-lerian gandalf-at-lerian requested a review from a team as a code owner March 19, 2026 14:49
@coderabbitai
Copy link

coderabbitai bot commented Mar 19, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 294b2f75-1aa4-4945-bcb8-248d96d22709

📥 Commits

Reviewing files that changed from the base of the PR and between 18a25d1 and 9d56cf7.

📒 Files selected for processing (2)
  • components/crm/Dockerfile
  • components/ledger/Dockerfile

Walkthrough

This pull request updates the github.com/LerianStudio/lib-commons/v4 dependency in go.mod from v4.1.0-beta.9 to v4.1.0-beta.10. It also updates comment lines in components/crm/Dockerfile and components/ledger/Dockerfile related to CI forced-rebuild behavior (adjusting referenced beta strings and whitespace). No source code logic, exported Go entities, build steps, runtime configuration, or public API signatures were changed.

🚥 Pre-merge checks | ✅ 1 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is missing the required Pull Request Type checklist and most of the Checklist items specified in the template, though it does provide good context about the dependency update. Complete the Pull Request Type checklist (mark relevant box like Pipeline or Tests) and fill out the Checklist section with appropriate check marks for completed items.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: bumping lib-commons dependency to a specific beta version, which aligns with the changeset's primary objective.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@go.mod`:
- Line 103: You updated the go.mod dependency to
"github.com/LerianStudio/lib-commons/v4 v4.1.0-beta.10" which is a pre-release
with behavior changes; before merging, run full integration tests and verify
health-check endpoints (lib-auth compatibility), MongoDB connections (authSource
default), OTEL pipeline endpoint normalization, and HTTP client insecure-mode
behavior; if any test fails, either revert to the previous stable version or
implement compatibility fixes in the code paths that interact with lib-commons
(search for usages of the lib-commons client/helpers in your repo to locate
where to adjust behavior).

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: a341c23c-17c7-4920-be39-6d786de4c98f

📥 Commits

Reviewing files that changed from the base of the PR and between 4ad72bf and 18a25d1.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (1)
  • go.mod

@gandalf-at-lerian gandalf-at-lerian requested a review from a team as a code owner March 19, 2026 14:59
@lerian-studio
Copy link
Contributor

📊 Unit Test Coverage Report: midaz-ledger

Metric Value
Overall Coverage 87.1% ✅ PASS
Threshold 85%

Coverage by Package

Package Coverage
github.com/LerianStudio/midaz/v3/components/ledger/internal/adapters/http/in 86.8%

Generated by Go PR Analysis workflow

@lerian-studio
Copy link
Contributor

📊 Unit Test Coverage Report: midaz-crm

Metric Value
Overall Coverage 87.7% ✅ PASS
Threshold 85%

Coverage by Package

Package Coverage
github.com/LerianStudio/midaz/v3/components/crm/internal/adapters/http/in 86.2%
github.com/LerianStudio/midaz/v3/components/crm/internal/adapters/mongodb/alias 92.1%
github.com/LerianStudio/midaz/v3/components/crm/internal/adapters/mongodb/holder 87.1%
github.com/LerianStudio/midaz/v3/components/crm/internal/services 95.2%

Generated by Go PR Analysis workflow

@github-actions
Copy link
Contributor

🔒 Security Scan Results — crm

Filesystem Scan

✅ No vulnerabilities or secrets found.

Docker Image Scan

✅ No vulnerabilities found.

All security checks passed.

@github-actions
Copy link
Contributor

🔒 Security Scan Results — ledger

Filesystem Scan

✅ No vulnerabilities or secrets found.

Docker Image Scan

✅ No vulnerabilities found.

All security checks passed.

@ClaraTersi ClaraTersi merged commit 7ac829a into develop Mar 19, 2026
31 checks passed
@ClaraTersi ClaraTersi deleted the chore/bump-lib-commons-beta10 branch March 19, 2026 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants