Guard null Controller.Value in trigger hooks (fixes recurring 'Object reference not set', #178) - #187
Open
RTN-VMR wants to merge 1 commit into
Open
Conversation
…s recurring Object reference not set)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Four trigger-output hooks in
TriggerHooks.csdereference a pawn's controller with.Value!and no null check:(the
trigger_multipleOnStartTouch/OnEndTouch and the twotrigger_teleportequivalents). When a pawn has no controller, transient during disconnect or a round/map transition,.Valueis null and.Value!.HandlethrowsNullReferenceException. Each hook has a surrounding try/catch that logsObject reference not set to an instance of an object.and continues, so it is not fatal, but on a busy server it fires constantly and the repeated throw/catch is measurable overhead. This is the symptom reported in #178.Fix
Resolve
.Controller.Valueinto a local, null-check it, and returnHookResult.Continuewhen null, identical to the existingactivator == nullguards already in these methods. Behaviour is unchanged when the controller is present. Applied to all four sites.Testing
Built clean (0/0). Verified live on a surf server: the recurring
trigger_multiple OnEndTouch"Object reference not set" spam is gone.Closes #178.