Repository navigation
馃浄 perf: Reduce Browser Work When Sending Documents - #16646
Merged
Merged
Conversation
Contributor
Author
|
Head: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A document send performs repeated synchronous localStorage work, and the composer redraws unchanged attachment previews and workspace state. These costs sit in the browser, not the model response path.
Batch all submitted file aliases into one ledger write before consuming attachments. Keep the tray's pending-action callback stable, and notify workspace consumers only when data, loading, or error state changes. Polling, recovery, upload delivery metadata, and cross-tab deletion protection remain intact. Model reasoning effort is unchanged.
Related to #16572.
How it works
Type of change
Testing
tsc --noEmit, scoped static checks, andgit diff --checkpassed.e689243d9. Document ledger writes fall from 3 to 1; override writes from 2 to 1; preview renders during typing fall from 19 to at most 1.libatk-1.0.so.0is unavailable. The CI Lighthouse lane covers the standard harness.9834b0a408b62b987d6ee054da0c6e645bdf4738: no findings. Browser send timing and real multi-tab runtime behavior were not profiled.Screenshots / recordings
No visual or layout changes. No browser recording captured.
Risk / compatibility
No API, configuration, or stored-data format changes. Workspace polling retains its existing interval and error recovery.
Checklist
Title verification: 馃浄 has 0 prior uses in 5,877 indexed commits through 2026-10-01 21:39:51 UTC. The sentinel passed. The sled represents removing friction from sending.