Repository navigation
🧹 fix: Stop Cache Audit From Logging Cache Keys and Values - #16995
Merged
Merged
Conversation
This was referenced Oct 11, 2026
berry-13
changed the title
berry-13
marked this pull request as ready for review
October 11, 2026 21:45
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8d93614199
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
codegraph-librechat
Bot
added
🗺️ Platform Security
berry-13
force-pushed
the
berry-13/redact-cache-audit
branch
from
October 12, 2026 12:11
799792a to
4141928
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
With
DEBUG_MEMORY_CACHEon and no Redis, the minute-interval cache audit printed every key and raw value of the in-memory TTL caches toconsole.log, bypassing the logger's redaction. Those stores include exchanged OpenID tokens, admin OAuth exchange codes, passkey challenges and cached messages.The audit now reports only namespace, entry count and TTL, the delete-failure warnings no longer print the cache key, and all of this module's cache diagnostics go through the winston logger so central redaction applies.
Stacked on #16994.
Type of change
Testing
Tested environments/configuration:
DEBUG_MEMORY_CACHE=true,USE_REDISoff.Automated tests:
api/cache/getLogStores.spec.js: seeds a TTL store with a secret key and value, runs the audit, and asserts neither appears in the output andconsole.logis never called.npx jest cache/getLogStores.spec.js: 1 passed.npx eslintandnpx prettier --checkon changed files: clean.Screenshots / recordings
No user-facing change
Risk / compatibility
The debug output now goes through
logger.debug, so it also requires debug-level logging to be visible, and it no longer lists individual keys.Checklist