Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
4 tasks done
berry-13
force-pushed
the
refactor/chat-resume-on-load
branch
from
October 15, 2026 15:47
6b607ba to
e48fa80
Compare
berry-13
added this pull request to stack #17153
October 15, 2026 16:13
berry-13
force-pushed
the
refactor/chat-resume-on-load
branch
from
October 16, 2026 19:38
e48fa80 to
b860d82
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
useResumeOnLoad.ts(1,087 lines) did four things in one hook: tracking runs the server owes a conversation (queued-turn receipts, the active-job list and the quiet-window latch), re-arming the resume check when such a run is announced orresumeStreamasks, settling what a run that ended while the pane was away left behind, and building the resume submission itself. It also carried its own copies of the steer-chip seed and settle callbacks thatuseResumableSSEalready had.This splits it by responsibility in
client/src/hooks/SSE/:useOwedSuccessor(the owed-run latch),useResumeAnnouncements(the re-arm on announcements and resume requests), andfinished.ts(settling a finished run), with the steer chips taken from the shareduseSteerChipsinstead of the duplicated callbacks.useResumeOnLoad.tskeeps the resume decision and is now 437 lines. No behavior changes. Stacked on #17133.Type of change
Testing
Tested environments/configuration:
Not applicable: the logic is moved, not changed; the two removed steer callbacks were line-for-line the shared ones.
Automated tests:
useResumeOnLoad.spec.tsx(3,100 lines) and the rest of the hooks/SSE and hooks/Chat specs plus data-provider/SSE, unchanged: 1148 pass.npx tsc --noEmitinclient, eslint, prettier and sort-imports on the changed files: clean.Screenshots / recordings
No user-facing change.
Risk / compatibility
None.
Checklist